Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 334263010: Mojo: Add GetMinimumLogLevel() to the logger interface. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Add GetMinimumLogLevel() to the logger interface. We'll want this to be able to implement efficient, base/logging.h-like macros (with the similar behavior -- i.e., don't evaluate the stream if it's not going to be logged). R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277779

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -17 lines) Patch
M mojo/environment/default_logger_impl.cc View 1 chunk +35 lines, -15 lines 0 comments Download
M mojo/public/c/environment/logger.h View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/public/cpp/environment/environment.h View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/cpp/environment/lib/default_logger.cc View 2 chunks +23 lines, -1 line 0 comments Download
A mojo/public/cpp/environment/lib/default_logger_internal.h View 1 chunk +20 lines, -0 lines 0 comments Download
M mojo/public/cpp/environment/lib/environment.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M mojo/public/cpp/environment/tests/logger_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/331143007/, which remove base::logging.*'s "error report" log severity.)
6 years, 6 months ago (2014-06-16 22:45:13 UTC) #1
darin (slow to review)
LGTM
6 years, 6 months ago (2014-06-16 23:58:22 UTC) #2
viettrungluu
6 years, 6 months ago (2014-06-17 16:43:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r277779.

Powered by Google App Engine
This is Rietveld 408576698