Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 334253006: Notify SyncNetworkChannel about GCM connection state (Closed)

Created:
6 years, 6 months ago by pavely
Modified:
6 years, 6 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, Nicolas Zea
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Notify SyncNetworkChannel about GCM connection state This change propagates GCM connection state from GCMInvalidationBridge to SyncNetworkChannel where based on this notification overall invalidations state is updated. This change still has issue that when GCM connection is down but HTTP request succeeds then status is updated to NOTIFICATIONS_ENABLED. Fixing this requires minor refactoring which I would like to pull into separate change. BUG=378536 R=rlarocque@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278225

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -16 lines) Patch
M chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc View 8 chunks +33 lines, -8 lines 0 comments Download
M components/invalidation/gcm_invalidation_bridge.cc View 5 chunks +23 lines, -4 lines 0 comments Download
M components/invalidation/gcm_network_channel.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/invalidation/gcm_network_channel.cc View 2 chunks +20 lines, -1 line 0 comments Download
M components/invalidation/gcm_network_channel_delegate.h View 1 chunk +8 lines, -1 line 0 comments Download
M components/invalidation/gcm_network_channel_unittest.cc View 4 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pavely
6 years, 6 months ago (2014-06-18 00:48:52 UTC) #1
rlarocque
lgtm https://codereview.chromium.org/334253006/diff/1/components/invalidation/gcm_network_channel.h File components/invalidation/gcm_network_channel.h (right): https://codereview.chromium.org/334253006/diff/1/components/invalidation/gcm_network_channel.h#newcode97 components/invalidation/gcm_network_channel.h:97: GCMNetworkChannelDelegate::ConnectionState conneciton_state); typo: conneciton_state
6 years, 6 months ago (2014-06-18 16:55:25 UTC) #2
pavely
The CQ bit was checked by pavely@chromium.org
6 years, 6 months ago (2014-06-18 17:13:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavely@chromium.org/334253006/20001
6 years, 6 months ago (2014-06-18 17:14:36 UTC) #4
pavely
https://codereview.chromium.org/334253006/diff/1/components/invalidation/gcm_network_channel.h File components/invalidation/gcm_network_channel.h (right): https://codereview.chromium.org/334253006/diff/1/components/invalidation/gcm_network_channel.h#newcode97 components/invalidation/gcm_network_channel.h:97: GCMNetworkChannelDelegate::ConnectionState conneciton_state); On 2014/06/18 16:55:25, rlarocque wrote: > typo: ...
6 years, 6 months ago (2014-06-18 17:16:08 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 01:28:12 UTC) #6
Message was sent while issue was closed.
Change committed as 278225

Powered by Google App Engine
This is Rietveld 408576698