Custom Elements: Encapsulates Async and Sync Queues into one class.

Source/core/dom/custom/CustomElementMicrotaskQueue.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef CustomElementMicrotaskQueue_h
 #define CustomElementMicrotaskQueue_h
 
-#include "core/dom/custom/CustomElementMicrotaskStep.h"
-#include "platform/heap/Handle.h"
-#include "wtf/OwnPtr.h"
-#include "wtf/PassOwnPtr.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefCounted.h"
-#include "wtf/RefPtr.h"
-#include "wtf/Vector.h"
+#include "core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h"
+#include "core/dom/custom/CustomElementSyncMicrotaskQueue.h"
 
 namespace WebCore {
 
-class CustomElementMicrotaskQueueBase : public RefCountedWillBeGarbageCollectedFinalized<CustomElementMicrotaskQueueBase> {
-    WTF_MAKE_NONCOPYABLE(CustomElementMicrotaskQueueBase);
+class HTMLImportLoader;
+
+class CustomElementMicrotaskQueue : public RefCountedWillBeGarbageCollectedFinalized<CustomElementMicrotaskQueue> {

[dominicc (has gone to gerrit), 2014/06/17 00:29:23]

Shouldn't you IWYU RefCountedWillBeGarbageCollectedFinalized, etc.?

[dominicc (has gone to gerrit), 2014/06/17 00:29:23]

I think the naming of these types is wrong.

Given CEMQ, CESyncMQ and CEMQBase I think it would be reasonable to expect

CEMQ : CEMQBase

and some relationship to CESyncMQ, perhaps because of the presence of CEMQBase
something like

CESyncMQ : CEMQBase.

I think you need to think of some names that reinforce the distinctions between
these types. Otherwise it is just AdjectiveSaladNoun.

[Hajime Morrita, 2014/06/17 17:19:51]

Done.

[Hajime Morrita, 2014/06/17 17:19:51]

Well, right. This isn't queue at all. Renaed to
QustomElementPendingMicrotaskSet.

+    WTF_MAKE_NONCOPYABLE(CustomElementMicrotaskQueue);
 public:
-    virtual ~CustomElementMicrotaskQueueBase() { }
+    static PassRefPtrWillBeRawPtr<CustomElementMicrotaskQueue> create() { return adoptRefWillBeNoop(new CustomElementMicrotaskQueue()); }
 
-    bool isEmpty() const { return m_queue.isEmpty(); }
+    CustomElementMicrotaskQueue();

[dominicc (has gone to gerrit), 2014/06/17 00:29:23]

Why is this visible?

[Hajime Morrita, 2014/06/17 17:19:51]

Done.

+
+    void enqueue(HTMLImportLoader* parentLoader, PassOwnPtrWillBeRawPtr<CustomElementMicrotaskStep>);
+    void enqueue(HTMLImportLoader* parentLoader, PassOwnPtrWillBeRawPtr<CustomElementMicrotaskImportStep>, bool importIsSync);
+
     void dispatch();
-
     void trace(Visitor*);
 
 #if !defined(NDEBUG)
     void show(unsigned indent);
 #endif
 
-protected:
-    CustomElementMicrotaskQueueBase() { }
-    virtual void doDispatch() = 0;
-
-    WillBeHeapVector<OwnPtrWillBeMember<CustomElementMicrotaskStep> > m_queue;
-};
-
-class CustomElementMicrotaskQueue : public CustomElementMicrotaskQueueBase {
-public:
-    static PassRefPtrWillBeRawPtr<CustomElementMicrotaskQueue> create() { return adoptRefWillBeNoop(new CustomElementMicrotaskQueue()); }
-
-    void enqueue(PassOwnPtrWillBeRawPtr<CustomElementMicrotaskStep>);
-
 private:
-    CustomElementMicrotaskQueue() { }
-    virtual void doDispatch();
+    RefPtrWillBeMember<CustomElementSyncMicrotaskQueue> m_syncQueue;

[dominicc (has gone to gerrit), 2014/06/17 00:29:23]

Why do these need to be pointers? Are they shared anywhere? Why not just
members?

[Hajime Morrita, 2014/06/17 17:19:51]

Yes. They are ref counted objects and one of them is shared by a
CustomElementAsyncImportMicrotaskStep.

+    RefPtrWillBeMember<CustomElementAsyncImportMicrotaskQueue> m_asyncQueue;
 };
 
 }
 
 #endif // CustomElementMicrotaskQueue_h