Use suggested filename for "Save Link As"

Use suggested filename for "Save Link As"

Blink side changes to use suggested filename mentioned in
download attribute of anchor element.

BUG=366370
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176565

[Nikhil, 2014-06-16 16:13:23]

Blink side changes to use suggested filename when downloading file using "Save
Link As" option from context menu.

PTAL. Thanks!

[Nikhil, 2014-06-18 11:12:52]

Adding more reviewers based on OWNERS file. PTAL.

This is my first patch on Blink side; so please let me know if you have any
review comments and I'll incorporate them :)

Thanks!

[Inactive, 2014-06-18 12:37:54]

is it possible to cover this with a unit test?

https://codereview.chromium.org/334243004/diff/1/Source/web/ContextMenuClient...
File Source/web/ContextMenuClientImpl.cpp (right):

https://codereview.chromium.org/334243004/diff/1/Source/web/ContextMenuClient...
Source/web/ContextMenuClientImpl.cpp:375: // Extract suggested filename for
saving file
nit: please end comments with a period '.'

https://codereview.chromium.org/334243004/diff/1/public/web/WebContextMenuData.h
File public/web/WebContextMenuData.h (right):

https://codereview.chromium.org/334243004/diff/1/public/web/WebContextMenuDat...
public/web/WebContextMenuData.h:120: // Suggested filename for saving file
ditto.

[Nikhil, 2014-06-18 13:51:34]

I'll add test for this on browser side. Please let me know if that is okay.

Here is the link to WIP patch on browser side -
https://codereview.chromium.org/339153002/

https://codereview.chromium.org/334243004/diff/1/Source/web/ContextMenuClient...
File Source/web/ContextMenuClientImpl.cpp (right):

https://codereview.chromium.org/334243004/diff/1/Source/web/ContextMenuClient...
Source/web/ContextMenuClientImpl.cpp:375: // Extract suggested filename for
saving file
On 2014/06/18 12:37:54, Chris Dumez wrote:
> nit: please end comments with a period '.'

Done.

https://codereview.chromium.org/334243004/diff/1/public/web/WebContextMenuData.h
File public/web/WebContextMenuData.h (right):

https://codereview.chromium.org/334243004/diff/1/public/web/WebContextMenuDat...
public/web/WebContextMenuData.h:120: // Suggested filename for saving file
On 2014/06/18 12:37:54, Chris Dumez wrote:
> ditto.

Done.

[abarth-chromium, 2014-06-18 23:38:49]

https://codereview.chromium.org/334243004/diff/20001/Source/web/ContextMenuCl...
File Source/web/ContextMenuClientImpl.cpp (right):

https://codereview.chromium.org/334243004/diff/20001/Source/web/ContextMenuCl...
Source/web/ContextMenuClientImpl.cpp:379: }
Why not put this information in WebCore::ContextMenu ?

[asanka, 2014-06-19 21:22:19]

https://codereview.chromium.org/334243004/diff/20001/Source/web/ContextMenuCl...
File Source/web/ContextMenuClientImpl.cpp (right):

https://codereview.chromium.org/334243004/diff/20001/Source/web/ContextMenuCl...
Source/web/ContextMenuClientImpl.cpp:379: }
On 2014/06/18 23:38:48, abarth wrote:
> Why not put this information in WebCore::ContextMenu ?

As in, eliminate WebContextMenuData?

[abarth-chromium, 2014-06-19 23:50:35]

LGTM

Ok, this is fine

[commit-bot: I haz the power, 2014-06-19 23:51:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/n.bansal@samsung.com/334243004/20001

[commit-bot: I haz the power, 2014-06-20 01:01:02]

Change committed as 176565