Issue 334243002: Version 3.26.31.4 (merged r21509, r21858, r21525)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334243002: Version 3.26.31.4 (merged r21509, r21858, r21525) (Closed)

Created:
6 years, 6 months ago by Benedikt Meurer

Modified:
6 years, 6 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.26

Visibility:
Public.

Description

Version 3.26.31.4 (merged r21509, r21858, r21525) Avoid HeapObject check in HStoreNamedField. Add unit test for regression in GVN caused by field type tracking. MIPS: Avoid HeapObject check in HStoreNamedField. BUG=v8:3347 LOG=N R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21860

Patch Set 1 #

Created: 6 years, 6 months ago

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -147 lines)
M	src/arm/lithium-arm.cc	View	1 chunk	+1 line, -7 lines	0 comments
M	src/arm/lithium-codegen-arm.cc	View	3 chunks	+7 lines, -18 lines	0 comments
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+5 lines, -0 lines	0 comments
M	src/arm64/lithium-arm64.cc	View	1 chunk	+1 line, -7 lines	0 comments
M	src/arm64/lithium-codegen-arm64.cc	View	3 chunks	+9 lines, -15 lines	0 comments
M	src/arm64/macro-assembler-arm64.cc	View	1 chunk	+5 lines, -0 lines	0 comments
M	src/hydrogen.cc	View	1 chunk	+4 lines, -7 lines	0 comments
M	src/hydrogen-instructions.h	View	1 chunk	+6 lines, -0 lines	0 comments
M	src/hydrogen-instructions.cc	View	2 chunks	+1 line, -1 line	0 comments
M	src/ia32/lithium-codegen-ia32.cc	View	2 chunks	+6 lines, -24 lines	0 comments
M	src/ia32/lithium-ia32.cc	View	1 chunk	+1 line, -10 lines	0 comments
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+5 lines, -0 lines	0 comments
M	src/mips/lithium-codegen-mips.cc	View	3 chunks	+7 lines, -18 lines	0 comments
M	src/mips/lithium-mips.cc	View	1 chunk	+1 line, -7 lines	0 comments
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+5 lines, -0 lines	0 comments
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+6 lines, -23 lines	0 comments
M	src/x64/lithium-x64.cc	View	1 chunk	+1 line, -9 lines	0 comments
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+5 lines, -0 lines	0 comments
A	test/mjsunit/regress/regress-gvn-ftt.js	View	1 chunk	+27 lines, -0 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Committed patchset #1 manually as r21860 (tree was closed).

6 years, 6 months ago (2014-06-16 13:44:11 UTC) #3

Sven Panne

6 years, 6 months ago (2014-06-16 14:35:40 UTC) #4

Message was sent while issue was closed.

On 2014/06/16 13:44:11, Benedikt Meurer wrote:
> Committed patchset #1 manually as r21860 (tree was closed).

This doesn't even compile on x64... :-/

Expand Messages | Collapse Messages