Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 33423002: add tests for SkDocument (Closed)

Created:
7 years, 2 months ago by edisonn
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com, bungeman-skia, caryclark
Visibility:
Public.

Description

add tests for SkDocument Committed: http://code.google.com/p/skia/source/detail?r=11907

Patch Set 1 #

Total comments: 4

Patch Set 2 : enforce empty file on abort #

Patch Set 3 : make functios static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -0 lines) Patch
M gyp/tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A tests/DocumentTest.cpp View 1 2 1 chunk +106 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
edisonn
7 years, 2 months ago (2013-10-21 18:48:13 UTC) #1
reed1
lgtm
7 years, 2 months ago (2013-10-21 18:54:28 UTC) #2
vandebo (ex-Chrome)
LGTM https://codereview.chromium.org/33423002/diff/1/tests/DocumentTest.cpp File tests/DocumentTest.cpp (right): https://codereview.chromium.org/33423002/diff/1/tests/DocumentTest.cpp#newcode56 tests/DocumentTest.cpp:56: // If a file is created, it should ...
7 years, 2 months ago (2013-10-21 19:02:42 UTC) #3
edisonn
https://codereview.chromium.org/33423002/diff/1/tests/DocumentTest.cpp File tests/DocumentTest.cpp (right): https://codereview.chromium.org/33423002/diff/1/tests/DocumentTest.cpp#newcode56 tests/DocumentTest.cpp:56: // If a file is created, it should be ...
7 years, 2 months ago (2013-10-21 19:14:55 UTC) #4
vandebo (ex-Chrome)
LGTM
7 years, 2 months ago (2013-10-21 19:19:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/edisonn@google.com/33423002/80001
7 years, 2 months ago (2013-10-22 14:09:46 UTC) #6
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildEverything, BuildTests http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=874
7 years, 2 months ago (2013-10-22 14:20:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/edisonn@google.com/33423002/200001
7 years, 2 months ago (2013-10-22 14:37:26 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 14:49:05 UTC) #9
Message was sent while issue was closed.
Change committed as 11907

Powered by Google App Engine
This is Rietveld 408576698