Issue 334223009: Oilpan: Mark SVGElement::InvalidationGuard and SVGElement::InstanceUpdateBlocker STACK_ALLOCATED().

Issue 334223009: Oilpan: Mark SVGElement::InvalidationGuard and SVGElement::InstanceUpdateBlocker STACK_ALLOCATED(). (Closed)

Created:
6 years, 6 months ago by tkent

Modified:
6 years, 6 months ago

Reviewers:
oilpan-reviews, haraken, kouhei (in TOK)

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Mark SVGElement::InvalidationGuard and SVGElement::InstanceUpdateBlocker STACK_ALLOCATED(). and makes their element members Member<>. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176271

Patch Set 1 #

Total comments: 3

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	Source/core/svg/SVGElement.h	View		1 chunk	+5 lines, -2 lines	3 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/334223009/diff/1/Source/core/svg/SVGElement.h File Source/core/svg/SVGElement.h (right): https://codereview.chromium.org/334223009/diff/1/Source/core/svg/SVGElement.h#newcode166 Source/core/svg/SVGElement.h:166: InvalidationGuard(SVGElement* element) : m_element(element) { } Add explicit. ...

6 years, 6 months ago (2014-06-17 00:52:48 UTC) #3

tkent

https://codereview.chromium.org/334223009/diff/1/Source/core/svg/SVGElement.h File Source/core/svg/SVGElement.h (right): https://codereview.chromium.org/334223009/diff/1/Source/core/svg/SVGElement.h#newcode166 Source/core/svg/SVGElement.h:166: InvalidationGuard(SVGElement* element) : m_element(element) { } On 2014/06/17 00:52:48, ...

6 years, 6 months ago (2014-06-17 01:40:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/334223009/1

6 years, 6 months ago (2014-06-17 01:42:05 UTC) #6

Message was sent while issue was closed.

Change committed as 176271

Expand Messages | Collapse Messages