Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 334223003: Battery Status API: end-to-end browsertests and default values. (Closed)

Created:
6 years, 6 months ago by timvolodine
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Battery Status API: end-to-end browsertests and default values. This patch adds end-to-end testing for the Battery Status API. Also a small fix in battery_status_service to return default values if battery_status_manager fails to start (e.g. no battery or no implementation). That way the promise on the blink side will resolve with default values as according to the specification. BUG=122593, 360068 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278097

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -6 lines) Patch
A content/browser/battery_status/battery_status_browsertest.cc View 1 1 chunk +167 lines, -0 lines 0 comments Download
M content/browser/battery_status/battery_status_service.cc View 3 chunks +11 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/battery_status/battery_status_default_test.html View 1 chunk +36 lines, -0 lines 0 comments Download
A content/test/data/battery_status/battery_status_event_listener_test.html View 1 chunk +34 lines, -0 lines 0 comments Download
A content/test/data/battery_status/battery_status_promise_resolution_test.html View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
timvolodine
6 years, 6 months ago (2014-06-16 15:08:40 UTC) #1
Michael van Ouwerkerk
LGTM but the battery tests seem to fail on the release bots.
6 years, 6 months ago (2014-06-17 12:46:48 UTC) #2
timvolodine
On 2014/06/17 12:46:48, Michael van Ouwerkerk wrote: > LGTM but the battery tests seem to ...
6 years, 6 months ago (2014-06-17 13:37:15 UTC) #3
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 6 months ago (2014-06-18 15:43:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/334223003/20001
6 years, 6 months ago (2014-06-18 15:44:28 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 16:24:31 UTC) #6
Message was sent while issue was closed.
Change committed as 278097

Powered by Google App Engine
This is Rietveld 408576698