Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334183003: DevTools: fixed UI glitches of inlined DataGrid. (Closed)

Created:
6 years, 6 months ago by eustas
Modified:
6 years, 5 months ago
Reviewers:
aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: fixed UI glitches of inlined DataGrid. 1) fix inlined DataGrid columns widths 2) fix left border 3) do not show corner column BUG=316092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176305

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Patch Set 3 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M Source/devtools/front_end/dataGrid.css View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui/DataGrid.js View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
eustas
6 years, 6 months ago (2014-06-16 08:13:05 UTC) #1
aandrey
lgtm https://codereview.chromium.org/334183003/diff/1/Source/devtools/front_end/ui/DataGrid.js File Source/devtools/front_end/ui/DataGrid.js (right): https://codereview.chromium.org/334183003/diff/1/Source/devtools/front_end/ui/DataGrid.js#newcode675 Source/devtools/front_end/ui/DataGrid.js:675: if (!this.element.offsetWidth) lets put it into a local ...
6 years, 6 months ago (2014-06-16 08:25:43 UTC) #2
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-17 06:01:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/334183003/20001
6 years, 6 months ago (2014-06-17 06:01:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 07:43:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12263)
6 years, 6 months ago (2014-06-17 07:43:20 UTC) #6
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-17 09:17:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/334183003/40001
6 years, 6 months ago (2014-06-17 09:18:09 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 10:29:45 UTC) #9
Message was sent while issue was closed. 
Change committed as 176305

Powered by Google App Engine
This is Rietveld 408576698