Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: content/common/gpu/image_transport_surface_mac.mm

Issue 334173006: Clean up GLSurfaceCGL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate review feedback Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/image_transport_surface_mac.cc ('k') | content/content_common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/image_transport_surface_mac.mm
diff --git a/content/common/gpu/image_transport_surface_mac.mm b/content/common/gpu/image_transport_surface_mac.mm
new file mode 100644
index 0000000000000000000000000000000000000000..7244f28dcdf9612016440d0ef830c726d87a65f8
--- /dev/null
+++ b/content/common/gpu/image_transport_surface_mac.mm
@@ -0,0 +1,74 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/common/gpu/image_transport_surface_fbo_mac.h"
+
+#include "content/common/gpu/gpu_messages.h"
+#include "content/common/gpu/image_transport_surface_iosurface_mac.h"
+#include "ui/gfx/native_widget_types.h"
+#include "ui/gl/gl_context.h"
+#include "ui/gl/gl_implementation.h"
+#include "ui/gl/gl_surface_osmesa.h"
+
+namespace content {
+namespace {
+
+// A subclass of GLSurfaceOSMesa that doesn't print an error message when
+// SwapBuffers() is called.
+class DRTSurfaceOSMesa : public gfx::GLSurfaceOSMesa {
+ public:
+ // Size doesn't matter, the surface is resized to the right size later.
+ DRTSurfaceOSMesa() : GLSurfaceOSMesa(GL_RGBA, gfx::Size(1, 1)) {}
+
+ // Implement a subset of GLSurface.
+ virtual bool SwapBuffers() OVERRIDE;
+
+ private:
+ virtual ~DRTSurfaceOSMesa() {}
+ DISALLOW_COPY_AND_ASSIGN(DRTSurfaceOSMesa);
+};
+
+bool DRTSurfaceOSMesa::SwapBuffers() {
+ return true;
+}
+
+bool g_allow_os_mesa = false;
+
+} // namespace
+
+// static
+scoped_refptr<gfx::GLSurface> ImageTransportSurface::CreateNativeSurface(
+ GpuChannelManager* manager,
+ GpuCommandBufferStub* stub,
+ const gfx::GLSurfaceHandle& surface_handle) {
+ DCHECK(surface_handle.transport_type == gfx::NATIVE_DIRECT ||
+ surface_handle.transport_type == gfx::NATIVE_TRANSPORT);
+
+ switch (gfx::GetGLImplementation()) {
+ case gfx::kGLImplementationDesktopGL:
+ case gfx::kGLImplementationAppleGL:
+ return scoped_refptr<gfx::GLSurface>(new ImageTransportSurfaceFBO(
+ new IOSurfaceStorageProvider, manager, stub, surface_handle.handle));
+ default:
+ // Content shell in DRT mode spins up a gpu process which needs an
+ // image transport surface, but that surface isn't used to read pixel
+ // baselines. So this is mostly a dummy surface.
+ if (!g_allow_os_mesa) {
+ NOTREACHED();
+ return scoped_refptr<gfx::GLSurface>();
+ }
+ scoped_refptr<gfx::GLSurface> surface(new DRTSurfaceOSMesa());
+ if (!surface.get() || !surface->Initialize())
+ return surface;
+ return scoped_refptr<gfx::GLSurface>(new PassThroughImageTransportSurface(
+ manager, stub, surface.get()));
+ }
+}
+
+// static
+void ImageTransportSurface::SetAllowOSMesaForTesting(bool allow) {
+ g_allow_os_mesa = allow;
+}
+
+} // namespace content
« no previous file with comments | « content/common/gpu/image_transport_surface_mac.cc ('k') | content/content_common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698