content/browser/compositor/browser_compositor_view_mac.mm - Issue 334173006: Clean up GLSurfaceCGL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/browser_compositor_view_mac.mm

Issue 334173006: Clean up GLSurfaceCGL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate review feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/compositor/browser_compositor_view_mac.mm

diff --git a/content/browser/compositor/browser_compositor_view_mac.mm b/content/browser/compositor/browser_compositor_view_mac.mm

index 93440ee0bd921635145710103ac218e8178c6405..0a89e6910757dd5ee37eaecd116d8487c6db5e2c 100644

--- a/content/browser/compositor/browser_compositor_view_mac.mm

+++ b/content/browser/compositor/browser_compositor_view_mac.mm

@@ -48,7 +48,7 @@ class BrowserCompositorViewMacHelper : public CompositingIOSurfaceLayerClient {

// compositing should never be called. Log an error if they are.

@implementation NSView (BrowserCompositorView)

-- (void)gotAcceleratedIOSurfaceFrame:(uint64)surface_handle

+- (void)gotAcceleratedIOSurfaceFrame:(IOSurfaceID)surface_handle

withOutputSurfaceID:(int)surface_id

withPixelSize:(gfx::Size)pixel_size

withScaleFactor:(float)scale_factor {

@@ -148,7 +148,7 @@ class BrowserCompositorViewMacHelper : public CompositingIOSurfaceLayerClient {

return compositor_.get();

}

-- (void)gotAcceleratedIOSurfaceFrame:(uint64)surface_handle

+- (void)gotAcceleratedIOSurfaceFrame:(IOSurfaceID)surface_handle

withOutputSurfaceID:(int)surface_id

withPixelSize:(gfx::Size)pixel_size

withScaleFactor:(float)scale_factor {