Issue 334173005: Add --enable-show-modal-dialog to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334173005: Add --enable-show-modal-dialog to chrome (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 6 months ago

Reviewers:
jamesr, eseidel, Andrew T Wilson (Slow), abarth-chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Add --enable-show-modal-dialog to chrome This flag will be controlled via enterprise policy to reenable the deprecated window.showModalDialog API to extend the time window for porting apps to other APIs. The flag will eventually be removed as well. BUG=345831 R=atwilson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277858

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -0 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_render_process_observer.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

jochen (gone - plz use gerrit)

The CQ bit was checked by jochen@chromium.org

6 years, 6 months ago (2014-06-17 19:28:49 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/334173005/1

6 years, 6 months ago (2014-06-17 19:30:03 UTC) #7

Message was sent while issue was closed.

Change committed as 277858