Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Side by Side Diff: media/base/pipeline_unittest.cc

Issue 334163002: Revert of Fix seeking when the start time is non-zero. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/base/pipeline.cc ('k') | media/filters/chunk_demuxer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/test/simple_test_tick_clock.h" 10 #include "base/test/simple_test_tick_clock.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 base::Unretained(this))); 100 base::Unretained(this)));
101 scoped_ptr<TextRenderer> text_renderer(text_renderer_); 101 scoped_ptr<TextRenderer> text_renderer(text_renderer_);
102 filter_collection_->SetTextRenderer(text_renderer.Pass()); 102 filter_collection_->SetTextRenderer(text_renderer.Pass());
103 103
104 // InitializeDemuxer() adds overriding expectations for expected non-NULL 104 // InitializeDemuxer() adds overriding expectations for expected non-NULL
105 // streams. 105 // streams.
106 DemuxerStream* null_pointer = NULL; 106 DemuxerStream* null_pointer = NULL;
107 EXPECT_CALL(*demuxer_, GetStream(_)) 107 EXPECT_CALL(*demuxer_, GetStream(_))
108 .WillRepeatedly(Return(null_pointer)); 108 .WillRepeatedly(Return(null_pointer));
109 109
110 EXPECT_CALL(*demuxer_, GetStartTime())
111 .WillRepeatedly(Return(base::TimeDelta()));
112
110 EXPECT_CALL(*demuxer_, GetTimelineOffset()) 113 EXPECT_CALL(*demuxer_, GetTimelineOffset())
111 .WillRepeatedly(Return(base::Time())); 114 .WillRepeatedly(Return(base::Time()));
112 115
113 EXPECT_CALL(*demuxer_, GetLiveness()) 116 EXPECT_CALL(*demuxer_, GetLiveness())
114 .WillRepeatedly(Return(Demuxer::LIVENESS_UNKNOWN)); 117 .WillRepeatedly(Return(Demuxer::LIVENESS_UNKNOWN));
115 } 118 }
116 119
117 virtual ~PipelineTest() { 120 virtual ~PipelineTest() {
118 if (!pipeline_ || !pipeline_->IsRunning()) 121 if (!pipeline_ || !pipeline_->IsRunning())
119 return; 122 return;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 return stream.Pass(); 167 return stream.Pass();
165 } 168 }
166 169
167 // Sets up expectations to allow the video renderer to initialize. 170 // Sets up expectations to allow the video renderer to initialize.
168 void InitializeVideoRenderer(DemuxerStream* stream) { 171 void InitializeVideoRenderer(DemuxerStream* stream) {
169 EXPECT_CALL(*video_renderer_, Initialize(stream, _, _, _, _, _, _, _, _)) 172 EXPECT_CALL(*video_renderer_, Initialize(stream, _, _, _, _, _, _, _, _))
170 .WillOnce(RunCallback<2>(PIPELINE_OK)); 173 .WillOnce(RunCallback<2>(PIPELINE_OK));
171 EXPECT_CALL(*video_renderer_, SetPlaybackRate(0.0f)); 174 EXPECT_CALL(*video_renderer_, SetPlaybackRate(0.0f));
172 175
173 // Startup sequence. 176 // Startup sequence.
174 EXPECT_CALL(*video_renderer_, Preroll(base::TimeDelta(), _)) 177 EXPECT_CALL(*video_renderer_, Preroll(demuxer_->GetStartTime(), _))
175 .WillOnce(RunCallback<1>(PIPELINE_OK)); 178 .WillOnce(RunCallback<1>(PIPELINE_OK));
176 EXPECT_CALL(*video_renderer_, Play(_)) 179 EXPECT_CALL(*video_renderer_, Play(_))
177 .WillOnce(RunClosure<0>()); 180 .WillOnce(RunClosure<0>());
178 } 181 }
179 182
180 // Sets up expectations to allow the audio renderer to initialize. 183 // Sets up expectations to allow the audio renderer to initialize.
181 void InitializeAudioRenderer(DemuxerStream* stream) { 184 void InitializeAudioRenderer(DemuxerStream* stream) {
182 EXPECT_CALL(*audio_renderer_, Initialize(stream, _, _, _, _, _, _)) 185 EXPECT_CALL(*audio_renderer_, Initialize(stream, _, _, _, _, _, _))
183 .WillOnce(DoAll(SaveArg<4>(&audio_time_cb_), 186 .WillOnce(DoAll(SaveArg<4>(&audio_time_cb_),
184 RunCallback<1>(PIPELINE_OK))); 187 RunCallback<1>(PIPELINE_OK)));
(...skipping 544 matching lines...) Expand 10 before | Expand all | Expand 10 after
729 .WillOnce(RunCallback<1>(PIPELINE_ERROR_READ)); 732 .WillOnce(RunCallback<1>(PIPELINE_ERROR_READ));
730 EXPECT_CALL(*demuxer_, Stop(_)) 733 EXPECT_CALL(*demuxer_, Stop(_))
731 .WillOnce(RunClosure<0>()); 734 .WillOnce(RunClosure<0>());
732 735
733 pipeline_->Seek(seek_time, base::Bind(&CallbackHelper::OnSeek, 736 pipeline_->Seek(seek_time, base::Bind(&CallbackHelper::OnSeek,
734 base::Unretained(&callbacks_))); 737 base::Unretained(&callbacks_)));
735 EXPECT_CALL(callbacks_, OnSeek(PIPELINE_ERROR_READ)); 738 EXPECT_CALL(callbacks_, OnSeek(PIPELINE_ERROR_READ));
736 message_loop_.RunUntilIdle(); 739 message_loop_.RunUntilIdle();
737 } 740 }
738 741
742 TEST_F(PipelineTest, StartTimeIsZero) {
743 CreateVideoStream();
744 MockDemuxerStreamVector streams;
745 streams.push_back(video_stream());
746
747 const base::TimeDelta kDuration = base::TimeDelta::FromSeconds(100);
748 InitializeDemuxer(&streams, kDuration);
749 InitializeVideoRenderer(video_stream());
750
751 InitializePipeline(PIPELINE_OK);
752 EXPECT_FALSE(metadata_.has_audio);
753 EXPECT_TRUE(metadata_.has_video);
754
755 EXPECT_EQ(base::TimeDelta(), pipeline_->GetMediaTime());
756 }
757
758 TEST_F(PipelineTest, StartTimeIsNonZero) {
759 const base::TimeDelta kStartTime = base::TimeDelta::FromSeconds(4);
760 const base::TimeDelta kDuration = base::TimeDelta::FromSeconds(100);
761
762 EXPECT_CALL(*demuxer_, GetStartTime())
763 .WillRepeatedly(Return(kStartTime));
764
765 CreateVideoStream();
766 MockDemuxerStreamVector streams;
767 streams.push_back(video_stream());
768
769 InitializeDemuxer(&streams, kDuration);
770 InitializeVideoRenderer(video_stream());
771
772 InitializePipeline(PIPELINE_OK);
773 EXPECT_FALSE(metadata_.has_audio);
774 EXPECT_TRUE(metadata_.has_video);
775
776 EXPECT_EQ(kStartTime, pipeline_->GetMediaTime());
777 }
778
739 static void RunTimeCB(const AudioRenderer::TimeCB& time_cb, 779 static void RunTimeCB(const AudioRenderer::TimeCB& time_cb,
740 int time_in_ms, 780 int time_in_ms,
741 int max_time_in_ms) { 781 int max_time_in_ms) {
742 time_cb.Run(base::TimeDelta::FromMilliseconds(time_in_ms), 782 time_cb.Run(base::TimeDelta::FromMilliseconds(time_in_ms),
743 base::TimeDelta::FromMilliseconds(max_time_in_ms)); 783 base::TimeDelta::FromMilliseconds(max_time_in_ms));
744 } 784 }
745 785
746 TEST_F(PipelineTest, AudioTimeUpdateDuringSeek) { 786 TEST_F(PipelineTest, AudioTimeUpdateDuringSeek) {
747 CreateAudioStream(); 787 CreateAudioStream();
748 MockDemuxerStreamVector streams; 788 MockDemuxerStreamVector streams;
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
1108 INSTANTIATE_TEARDOWN_TEST(Error, InitAudioRenderer); 1148 INSTANTIATE_TEARDOWN_TEST(Error, InitAudioRenderer);
1109 INSTANTIATE_TEARDOWN_TEST(Error, InitVideoRenderer); 1149 INSTANTIATE_TEARDOWN_TEST(Error, InitVideoRenderer);
1110 INSTANTIATE_TEARDOWN_TEST(Error, Flushing); 1150 INSTANTIATE_TEARDOWN_TEST(Error, Flushing);
1111 INSTANTIATE_TEARDOWN_TEST(Error, Seeking); 1151 INSTANTIATE_TEARDOWN_TEST(Error, Seeking);
1112 INSTANTIATE_TEARDOWN_TEST(Error, Prerolling); 1152 INSTANTIATE_TEARDOWN_TEST(Error, Prerolling);
1113 INSTANTIATE_TEARDOWN_TEST(Error, Playing); 1153 INSTANTIATE_TEARDOWN_TEST(Error, Playing);
1114 1154
1115 INSTANTIATE_TEARDOWN_TEST(ErrorAndStop, Playing); 1155 INSTANTIATE_TEARDOWN_TEST(ErrorAndStop, Playing);
1116 1156
1117 } // namespace media 1157 } // namespace media
OLDNEW
« no previous file with comments | « media/base/pipeline.cc ('k') | media/filters/chunk_demuxer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698