Issue 33413002: scroll: Tell the platform layer whether it can be scrolled by the user.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 33413002: scroll: Tell the platform layer whether it can be scrolled by the user. (Closed)

Created:
7 years, 2 months ago by sadrul

Modified:
7 years ago

Reviewers:
jamesr, qinmin

CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, dglazkov+blink, jamesr, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

scroll: Tell the platform layer whether it can be scrolled by the user. BUG=175502 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160177

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : test #

Patch Set 4 : tot-merge #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -3 lines)			Patch
M	Source/core/page/scrolling/ScrollingCoordinator.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/web/PinchViewports.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/tests/ScrollingCoordinatorChromiumTest.cpp	View	1 2 3	2 chunks	+56 lines, -0 lines	0 comments	Download
A +	Source/web/tests/data/overflow-hidden.html	View	1 2	2 chunks	+11 lines, -3 lines	0 comments	Download
M	public/platform/WebLayer.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

This is the blink-side patch for https://codereview.chromium.org/30793002/

7 years, 2 months ago (2013-10-21 20:17:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sadrul@chromium.org/33413002/140001

7 years, 2 months ago (2013-10-22 05:14:56 UTC) #3

qinmin

7 years ago (2013-12-06 22:00:52 UTC) #5

Message was sent while issue was closed.

Unfortunately, this change is causing crbug.com/322477.

When RenderWidget::Resize() is called, layout does not happen yet. So
ScrollView::setScrollbarModes() is called after
ScrollingCoordinator::scrollableAreaScrollLayerDidChange(). 
And ScrollView::setScrollbarModes() may not trigger
ScrollingCoordinator::scrollableAreaScrollLayerDidChange() to be called again,
thus making the page unable to scroll.

Expand Messages | Collapse Messages