Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 334113003: Deflake http/tests/navigation/ping-*. (Closed)

Created:
6 years, 6 months ago by Mike West
Modified:
6 years, 6 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Deflake http/tests/navigation/ping-*. This CL de-flakes the http/tests/navigation/ping-* suite by ensuring that each test generates its own ping file dump, and that the temp directory is consistently used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176335

Patch Set 1 #

Messages

Total messages: 9 (0 generated)
Mike West
Hey Kenneth, would you mind reviewing this small deflake patch? -mike
6 years, 6 months ago (2014-06-17 11:56:40 UTC) #1
kenneth.r.christiansen
lgtm
6 years, 6 months ago (2014-06-17 12:20:23 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 6 months ago (2014-06-17 12:25:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/334113003/1
6 years, 6 months ago (2014-06-17 12:26:04 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 13:55:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18053)
6 years, 6 months ago (2014-06-17 13:55:17 UTC) #6
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 6 months ago (2014-06-17 15:55:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/334113003/1
6 years, 6 months ago (2014-06-17 15:56:29 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 17:09:22 UTC) #9
Message was sent while issue was closed.
Change committed as 176335

Powered by Google App Engine
This is Rietveld 408576698