Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 334093002: Move Syzygy symbol files to 'exe' subdirectory as they were before. (Closed)

Created:
6 years, 6 months ago by chrisha
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move Syzygy symbol files to 'exe' subdirectory as they were before. The current script places the symbols in their own subdirectory, which breaks the expectations of the SyzyASAN build integration. BUG= TBR=sebmarchand@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/get_syzygy_binaries.py View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
chrisha
Committing this TBR to fix the ASAN builders ASAP.
6 years, 6 months ago (2014-06-15 15:17:19 UTC) #1
chrisha
The CQ bit was checked by chrisha@chromium.org
6 years, 6 months ago (2014-06-15 15:17:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/334093002/1
6 years, 6 months ago (2014-06-15 15:17:33 UTC) #3
Sébastien Marchand
LGTM, thanks for the quick fix.
6 years, 6 months ago (2014-06-15 15:28:55 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-15 18:28:49 UTC) #5
Message was sent while issue was closed.
Change committed as 277330

Powered by Google App Engine
This is Rietveld 408576698