Issue 334063002: Remove useless override of executionContext() in HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334063002: Remove useless override of executionContext() in HTMLMediaElement (Closed)

Created:
6 years, 6 months ago by Inactive

Modified:
6 years, 6 months ago

Reviewers:
tkent

CC:
blink-reviews, philipj_slow, feature-media-reviews_chromium.org, gasubic, sof, eae+blinkwatch, fs, eric.carlson_apple.com, vcarbune.chromium, blink-reviews-dom_chromium.org, dglazkov+blink, nessy, blink-reviews-html_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove useless override of executionContext() in HTMLMediaElement Remove useless override of executionContext() in HTMLMediaElement. This was previously done to remove ambiguity because HTMLMediaElement inherited two implementations of executionContext() from its base classes (Node and ActiveDOMObject). This CL gets rid of the override and uses a "using" statement instead to remove ambiguity, which is the proper way to do this. The executionContext() override in Node can now be marked as FINAL as a result. R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176167

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/dom/Node.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/html/HTMLMediaElement.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/334063002/1

6 years, 6 months ago (2014-06-15 23:35:40 UTC) #3

Message was sent while issue was closed.

Change committed as 176167

Expand Messages | Collapse Messages