Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 334063002: Remove useless override of executionContext() in HTMLMediaElement (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, philipj_slow, feature-media-reviews_chromium.org, gasubic, sof, eae+blinkwatch, fs, eric.carlson_apple.com, vcarbune.chromium, blink-reviews-dom_chromium.org, dglazkov+blink, nessy, blink-reviews-html_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove useless override of executionContext() in HTMLMediaElement Remove useless override of executionContext() in HTMLMediaElement. This was previously done to remove ambiguity because HTMLMediaElement inherited two implementations of executionContext() from its base classes (Node and ActiveDOMObject). This CL gets rid of the override and uses a "using" statement instead to remove ambiguity, which is the proper way to do this. The executionContext() override in Node can now be marked as FINAL as a result. R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 6 months ago (2014-06-15 01:28:48 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-15 23:35:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/334063002/1
6 years, 6 months ago (2014-06-15 23:35:40 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-15 23:38:01 UTC) #4
Message was sent while issue was closed.
Change committed as 176167

Powered by Google App Engine
This is Rietveld 408576698