Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 334053008: [SyncFS] Make task invocation in SyncTaskRunner async (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Make task invocation in SyncTaskRunner async SyncTaskRunner's task invocation tend to grow call stack deeper. This CL clears the call stack per task to avoid stack overflow. BUG=344769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278362

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Messages

Total messages: 7 (0 generated)
tzik
PTL
6 years, 6 months ago (2014-06-18 06:47:56 UTC) #1
peria
https://codereview.chromium.org/334053008/diff/1/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc File chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc (right): https://codereview.chromium.org/334053008/diff/1/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc#newcode649 chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc:649: // task1 blocks task2. task2's update should be pending ...
6 years, 6 months ago (2014-06-18 06:58:00 UTC) #2
tzik
https://codereview.chromium.org/334053008/diff/1/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc File chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc (right): https://codereview.chromium.org/334053008/diff/1/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc#newcode649 chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc:649: // task1 blocks task2. task2's update should be pending ...
6 years, 6 months ago (2014-06-19 04:04:57 UTC) #3
peria
lgtm
6 years, 6 months ago (2014-06-19 04:11:05 UTC) #4
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-19 07:06:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/334053008/20001
6 years, 6 months ago (2014-06-19 07:08:49 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 14:32:44 UTC) #7
Message was sent while issue was closed.
Change committed as 278362

Powered by Google App Engine
This is Rietveld 408576698