Android: Optimize PNG files in chrome/android/java/res.

Android: Optimize some PNG files in chrome/android/java/res.

Result: 283628 => 128506 bytes (155122 bytes: 54%)

R=newt@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278635

[Lei Zhang, 2014-06-18 02:02:29]

I noticed zip did a good job compressing these resources.

[aurimas (slooooooooow), 2014-06-18 02:08:00]

+newt I'm pretty sure that our build system crunches the pngs.

[Lei Zhang, 2014-06-18 02:09:56]

On 2014/06/18 02:08:00, aurimas wrote:
> +newt I'm pretty sure that our build system crunches the pngs.

I'm just messing with the public tree, if that makes a difference.

[newt (away), 2014-06-18 03:52:04]

I didn't know about optimize-png-files.sh, that's neat :)

Aurimas is correct, though, build/android/process_resources.py runs Android's
"aapt crunch" tool at build time to optimize all the png files in Android res
folders. So, this CL shouldn't affect the build results in any tangible way.
(You could measure this by comparing the size of the png files inside the APK
before and after this CL.)

It's fine to land this, but I don't think it will gain anything. As a downside,
this'll increase the git repository size by 170kb.

[Lei Zhang, 2014-06-18 04:19:24]

On 2014/06/18 03:52:04, newt wrote:
> I didn't know about optimize-png-files.sh, that's neat :)
> 
> Aurimas is correct, though, build/android/process_resources.py runs Android's
> "aapt crunch" tool at build time to optimize all the png files in Android res
> folders. So, this CL shouldn't affect the build results in any tangible way.
> (You could measure this by comparing the size of the png files inside the APK
> before and after this CL.)

optimize-png-files.sh does a better job though. Take
chrome/android/java/res/drawable-xhdpi/infobar_theme.png as an example. It's
1721 bytes currently. The crunched version at
out/Release/gen/chrome_java/res_crunched/drawable-xhdpi/infobar_theme.png is
1640 bytes, but the one in this CL is 1289 bytes.

> It's fine to land this, but I don't think it will gain anything. As a
downside,
> this'll increase the git repository size by 170kb.

That is one of the downsides of git. Sigh. :\

[Lei Zhang, 2014-06-18 04:31:40]

I also noticed chrome/android/java/res/mipmap-xxhdpi/app_icon.png, which this CL
takes from 24601 to 22520 bytes, but the crunched version is only 2418 bytes and
it doesn't even look like the original ?!

[newt (away), 2014-06-18 05:57:04]

On 2014/06/18 04:19:24, Lei Zhang wrote:
> On 2014/06/18 03:52:04, newt wrote:
> > I didn't know about optimize-png-files.sh, that's neat :)
> > 
> > Aurimas is correct, though, build/android/process_resources.py runs
Android's
> > "aapt crunch" tool at build time to optimize all the png files in Android
res
> > folders. So, this CL shouldn't affect the build results in any tangible way.
> > (You could measure this by comparing the size of the png files inside the
APK
> > before and after this CL.)
> 
> optimize-png-files.sh does a better job though. Take
> chrome/android/java/res/drawable-xhdpi/infobar_theme.png as an example. It's
> 1721 bytes currently. The crunched version at
> out/Release/gen/chrome_java/res_crunched/drawable-xhdpi/infobar_theme.png is
> 1640 bytes, but the one in this CL is 1289 bytes.

Nice. If optimize-png-files.sh does a better job, then let's use it!

> > It's fine to land this, but I don't think it will gain anything. As a
> downside,
> > this'll increase the git repository size by 170kb.
> 
> That is one of the downsides of git. Sigh. :\

[newt (away), 2014-06-18 06:01:08]

On 2014/06/18 04:31:40, Lei Zhang wrote:
> I also noticed chrome/android/java/res/mipmap-xxhdpi/app_icon.png, which this
CL
> takes from 24601 to 22520 bytes, but the crunched version is only 2418 bytes
and
> it doesn't even look like the original ?!

That's odd, though the app icon is displayed correctly on xxhdpi devices
AFAICT... Maybe Android does something tricky with images in mipmap, like
storing a diff against the scaled up smaller version of the image.

[newt (away), 2014-06-18 06:01:18]

lgtm

[newt (away), 2014-06-19 17:11:14]

FYI, I'm modifying all the infobar_*.png images soon. If you could revert
changes to those files before landing this, I'd appreciate it. I'll re-run
optimize-png-files.sh after updating the images. Thanks!

[Lei Zhang, 2014-06-20 06:41:22]

On 2014/06/19 17:11:14, newt wrote:
> FYI, I'm modifying all the infobar_*.png images soon. If you could revert
> changes to those files before landing this, I'd appreciate it. I'll re-run
> optimize-png-files.sh after updating the images. Thanks!

Ok, I excluded those and updated the savings results in the commit msg.

[Lei Zhang, 2014-06-20 06:49:35]

Committed patchset #3 manually as r278635 (presubmit successful).

[newt (away), 2014-06-20 16:11:28]

On 2014/06/20 06:41:22, Lei Zhang wrote:
> On 2014/06/19 17:11:14, newt wrote:
> > FYI, I'm modifying all the infobar_*.png images soon. If you could revert
> > changes to those files before landing this, I'd appreciate it. I'll re-run
> > optimize-png-files.sh after updating the images. Thanks!
> 
> Ok, I excluded those and updated the savings results in the commit msg.

Thanks :)