Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1880)

Issue 334053005: Remove dashing from gpu veto (Closed)

Created:
6 years, 6 months ago by egdaniel
Modified:
6 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove dashing from gpu veto With new veto our new veto test results look like the following: TP: true positive (picked to use gpu and gpu was faster) I: inderminate, the raster time is withing 5% of gpu time TP FP TN FN I old 21 9 15 12 3 new 29 12 11 6 3 There are three skps that tend to move from TN -> FP, however the absolute difference in their run times are not huge between them. The largest being desk_booking which is about 7.1 raster and 8.8 gpu. The other two skps are desk_yahooanswers and desk_linkedin BUG=skia: Committed: https://skia.googlesource.com/skia/+/12c2198535759ee9aae91ec385e8e31e5dbc12d7

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change to use wall timer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -22 lines) Patch
M src/core/SkPicturePlayback.h View 1 4 chunks +22 lines, -1 line 0 comments Download
M src/core/SkPicturePlayback.cpp View 2 chunks +34 lines, -6 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/test_gpuveto.py View 1 3 chunks +36 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
egdaniel
Here is the version of the veto with dashing removed. Do you think we should ...
6 years, 6 months ago (2014-06-17 21:21:02 UTC) #1
bsalomon
I don't think we should keep the existing dash veto because it is accidentally veto'ing ...
6 years, 6 months ago (2014-06-18 13:26:25 UTC) #2
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 6 months ago (2014-06-18 14:14:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/334053005/20001
6 years, 6 months ago (2014-06-18 14:15:16 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 14:34:43 UTC) #5
Message was sent while issue was closed.
Change committed as 12c2198535759ee9aae91ec385e8e31e5dbc12d7

Powered by Google App Engine
This is Rietveld 408576698