Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: extensions/browser/image_loader_unittest.cc

Issue 334053003: Moves extension_icon_image and image_loader to extensions/browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix / remove component_extension_resource_manager Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/image_loader_unittest.cc
diff --git a/chrome/browser/extensions/image_loader_unittest.cc b/extensions/browser/image_loader_unittest.cc
similarity index 96%
rename from chrome/browser/extensions/image_loader_unittest.cc
rename to extensions/browser/image_loader_unittest.cc
index 45cff827d7dc8d3d84affa51bcd4f600642d643b..d63bda8a82aedaedda76f6ab639021cbecddb2d6 100644
--- a/chrome/browser/extensions/image_loader_unittest.cc
+++ b/extensions/browser/image_loader_unittest.cc
@@ -2,15 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/extensions/image_loader.h"
+#include "extensions/browser/image_loader.h"
+#include "base/files/file_path.h"
#include "base/json/json_file_value_serializer.h"
#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
+#include "base/strings/string_util.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/common/chrome_paths.h"
#include "content/public/browser/notification_service.h"
#include "content/public/test/test_browser_thread.h"
+#include "extensions/browser/extensions_browser_client.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_icon_set.h"
@@ -316,6 +319,7 @@ TEST_F(ImageLoaderTest, LoadImageFamily) {
}
// Tests IsComponentExtensionResource function.
+// TODO(mukai): move this to ChromeExtensionsBrowserClient's test.
TEST_F(ImageLoaderTest, IsComponentExtensionResource) {
scoped_refptr<Extension> extension(CreateExtension(
"file_manager", Manifest::COMPONENT));
@@ -328,10 +332,10 @@ TEST_F(ImageLoaderTest, IsComponentExtensionResource) {
#if defined(OS_CHROMEOS)
int resource_id;
- ASSERT_EQ(true,
- ImageLoader::IsComponentExtensionResource(extension->path(),
- resource.relative_path(),
- &resource_id));
+ ASSERT_TRUE(extensions::ExtensionsBrowserClient::Get()->
+ IsComponentExtensionResource(extension->path(),
+ resource.relative_path(),
+ &resource_id));
ASSERT_EQ(IDR_FILE_MANAGER_ICON_16, resource_id);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698