Moves extension_icon_image and image_loader to extensions/browser

chrome/browser/extensions/extension_system_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_system_impl.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string_tokenizer.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/extensions/blacklist.h"
+#include "chrome/browser/extensions/chrome_component_extension_resource_manager.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/error_console/error_console.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system_factory.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/extension_warning_badge_service.h"
 #include "chrome/browser/extensions/extension_warning_set.h"
 #include "chrome/browser/extensions/install_verifier.h"
 #include "chrome/browser/extensions/navigation_observer.h"
@@ skipping 286 matching lines @@
       base::StringTokenizerT<CommandLine::StringType,
           CommandLine::StringType::const_iterator> t(path_list,
                                                      FILE_PATH_LITERAL(","));
       while (t.GetNext()) {
         std::string extension_id;
         UnpackedInstaller::Create(extension_service_.get())->
             LoadFromCommandLine(base::FilePath(t.token()), &extension_id);
       }
     }
   }
+
+  ComponentExtensionResourceManager::Set(

[James Cook, 2014/06/17 22:01:04]

I would prefer to do this through ExtensionsBrowserClient, see later comment. 
This will require a bit of changes to tests, but TestExtensionsBrowserClient
could be helpful.

[Jun Mukai, 2014/06/17 23:53:02]

Done.

+      new ChromeComponentExtensionResourceManager());
 }
 
 void ExtensionSystemImpl::Shared::Shutdown() {
+  ComponentExtensionResourceManager::Set(NULL);
   if (extension_warning_service_) {
     extension_warning_service_->RemoveObserver(
         extension_warning_badge_service_.get());
   }
   if (content_verifier_)
     content_verifier_->Shutdown();
   if (extension_service_)
     extension_service_->Shutdown();
 }
 
@@ skipping 198 matching lines @@
 void ExtensionSystemImpl::UnregisterExtensionWithRequestContexts(
     const std::string& extension_id,
     const UnloadedExtensionInfo::Reason reason) {
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(&InfoMap::RemoveExtension, info_map(), extension_id, reason));
 }
 
 }  // namespace extensions