Factored out calls to client.getPage to factor out common constants (timeout and buildbot name) and…

Factored out calls to client.getPage to factor out common constants (timeout and buildbot name) and to allow easy override in subclasses

BUG=160709
R=stip@google.com, phajdan@google.com, pgervais@google.com

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=278819

[pgervais, 2014-06-20 15:46:08]

Nicely done. lgtm.

https://codereview.chromium.org/334013004/diff/1/scripts/master/try_job_rietv...
File scripts/master/try_job_rietveld.py (right):

https://codereview.chromium.org/334013004/diff/1/scripts/master/try_job_rietv...
scripts/master/try_job_rietveld.py:238: return client.getPage(url,
agent='buildbot', timeout=2*60)
While we're at it, define this timeout in an instance variable.

[Sergiy Byelozyorov, 2014-06-20 19:22:09]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2014-06-20 19:22:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergiyb@chromium.org/334013004/20001

[commit-bot: I haz the power, 2014-06-20 19:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 19:23:39]

Presubmit check for 334013004-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    build/scripts/master/try_job_rietveld.py

Presubmit checks took 52.8s to calculate.

[pgervais, 2014-06-20 21:05:12]

The CQ bit was checked by pgervais@chromium.org

[commit-bot: I haz the power, 2014-06-20 21:05:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergiyb@chromium.org/334013004/20001

[commit-bot: I haz the power, 2014-06-20 21:06:23]

Change committed as 278819