Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 333993003: Add paper size support for printing to local printer on Windows. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add paper size support for local printing on Windows. Set windows paper is as ventor_id. Use windows paper id in Cloud Print Connector. BUG=239879, 382338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277562

Patch Set 1 #

Patch Set 2 : Sat 06/14/2014 0:17:22.22 #

Total comments: 2

Patch Set 3 : Mon 06/16/2014 11:56:53.27 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -24 lines) Patch
M chrome/service/cloud_print/cdd_conversion_win.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M printing/backend/print_backend_win.cc View 2 chunks +19 lines, -21 lines 0 comments Download
M printing/printing_context_win.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-14 07:18:04 UTC) #1
Noam Samuel
lgtm https://codereview.chromium.org/333993003/diff/2/chrome/service/cloud_print/cdd_conversion_win.cc File chrome/service/cloud_print/cdd_conversion_win.cc (right): https://codereview.chromium.org/333993003/diff/2/chrome/service/cloud_print/cdd_conversion_win.cc#newcode119 chrome/service/cloud_print/cdd_conversion_win.cc:119: } else if (width > 0 && height ...
6 years, 6 months ago (2014-06-16 18:24:25 UTC) #2
Vitaly Buka (NO REVIEWS)
fixed string conversion https://codereview.chromium.org/333993003/diff/2/chrome/service/cloud_print/cdd_conversion_win.cc File chrome/service/cloud_print/cdd_conversion_win.cc (right): https://codereview.chromium.org/333993003/diff/2/chrome/service/cloud_print/cdd_conversion_win.cc#newcode119 chrome/service/cloud_print/cdd_conversion_win.cc:119: } else if (width > 0 ...
6 years, 6 months ago (2014-06-16 18:58:38 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-16 18:59:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/333993003/30001
6 years, 6 months ago (2014-06-16 19:00:45 UTC) #5
Aleksey Shlyapnikov
lgtm
6 years, 6 months ago (2014-06-16 19:11:00 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 23:02:17 UTC) #7
Message was sent while issue was closed.
Change committed as 277562

Powered by Google App Engine
This is Rietveld 408576698