Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 333983003: device/bluetooth: Implement BluetoothGattConnection on Chrome OS. (Closed)

Created:
6 years, 6 months ago by armansito
Modified:
6 years, 6 months ago
Reviewers:
keybuk
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

device/bluetooth: Implement BluetoothGattConnection on Chrome OS. This patch adds BluetoothGattConnectionChromeOS and implements BluetoothDeviceChromeOS::CreateGattConnection. At this point, creating a connection simply calls org.bluez.Device1.Connect without pairing. BluetoothGattConnectionChromeOS::Disconnect currently doesn't do anything, at least until there is a system in bluetoothd for managing GATT connections properly between Chrome and its profiles and plugins. BUG=384620, 381305 TEST=device_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -3 lines) Patch
M chromeos/dbus/fake_bluetooth_device_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 3 chunks +16 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 6 chunks +88 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_gatt_connection_chromeos.h View 1 chunk +66 lines, -0 lines 0 comments Download
A device/bluetooth/bluetooth_gatt_connection_chromeos.cc View 1 chunk +107 lines, -0 lines 0 comments Download
A device/bluetooth/test/mock_bluetooth_gatt_connection.h View 1 chunk +25 lines, -0 lines 0 comments Download
A device/bluetooth/test/mock_bluetooth_gatt_connection.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
armansito
6 years, 6 months ago (2014-06-19 01:38:42 UTC) #1
keybuk
lgtm
6 years, 6 months ago (2014-06-19 17:10:37 UTC) #2
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 6 months ago (2014-06-19 17:14:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/333983003/1
6 years, 6 months ago (2014-06-19 17:16:38 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 04:40:49 UTC) #5
Message was sent while issue was closed.
Change committed as 278595

Powered by Google App Engine
This is Rietveld 408576698