Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 333943002: Oilpan: Fix the Android build. (Closed)

Created:
6 years, 6 months ago by Feng Qian
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix the build. Break Android build, clearly it was a typo. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176129

Patch Set 1 #

Total comments: 1

Patch Set 2 : as suggested by a reviewer #

Total comments: 1

Patch Set 3 : fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Nico
lgtm (broke in http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.cpp?r1=176013&r2=176012&pathrev=176013)
6 years, 6 months ago (2014-06-13 17:54:20 UTC) #1
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 6 months ago (2014-06-13 17:55:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/333943002/1
6 years, 6 months ago (2014-06-13 17:55:37 UTC) #3
Feng Qian
The CQ bit was unchecked by feng@chromium.org
6 years, 6 months ago (2014-06-13 17:57:10 UTC) #4
sof
https://codereview.chromium.org/333943002/diff/1/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/333943002/diff/1/Source/core/html/HTMLMediaElement.cpp#newcode377 Source/core/html/HTMLMediaElement.cpp:377: #if ENABLE(WEB_AUDIO) #if ENABLE(WEB_AUDIO) && !ENABLE(OILPAN) would be the ...
6 years, 6 months ago (2014-06-13 18:13:49 UTC) #5
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 6 months ago (2014-06-13 18:26:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/333943002/20001
6 years, 6 months ago (2014-06-13 18:26:48 UTC) #7
sof
lgtm, thanks for updating the CL. https://codereview.chromium.org/333943002/diff/20001/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/333943002/diff/20001/Source/core/html/HTMLMediaElement.cpp#newcode377 Source/core/html/HTMLMediaElement.cpp:377: #if ENABLE(WEB_AUDIO) && ...
6 years, 6 months ago (2014-06-13 18:54:31 UTC) #8
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 6 months ago (2014-06-13 18:56:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/333943002/40001
6 years, 6 months ago (2014-06-13 18:56:42 UTC) #10
Feng Qian
On 2014/06/13 18:54:31, sof wrote: > lgtm, thanks for updating the CL. > > https://codereview.chromium.org/333943002/diff/20001/Source/core/html/HTMLMediaElement.cpp ...
6 years, 6 months ago (2014-06-13 18:56:48 UTC) #11
commit-bot: I haz the power
Change committed as 176129
6 years, 6 months ago (2014-06-13 20:08:40 UTC) #12
haraken
6 years, 6 months ago (2014-06-14 00:34:36 UTC) #13
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698