build/android/pylib/screenshot.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/screenshot.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/screenshot.py

diff --git a/build/android/pylib/screenshot.py b/build/android/pylib/screenshot.py

index 5cf3c268591b5f10eae29409e67c3cfbd05604a6..a09bc3d0a130261a08828b875a90ee798e7bb569 100644

--- a/build/android/pylib/screenshot.py

+++ b/build/android/pylib/screenshot.py

@@ -76,7 +76,7 @@ class VideoRecorder(object):

self._is_started = False

if not self._recorder or not self._recorder_pids:

return

- self._device.old_interface.RunShellCommand(

+ self._device.RunShellCommand(

'kill -SIGINT ' + ' '.join(self._recorder_pids))

self._recorder.wait()

@@ -88,5 +88,5 @@ class VideoRecorder(object):

"""

self._device.old_interface.PullFileFromDevice(

self._device_file, self._host_file)

- self._device.old_interface.RunShellCommand('rm -f "%s"' % self._device_file)

+ self._device.RunShellCommand('rm -f "%s"' % self._device_file)

return self._host_file

« no previous file with comments | « build/android/pylib/ports.py ('k') | build/android/pylib/utils/emulator.py » ('j') | no next file with comments »