build/android/pylib/ports.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/ports.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/ports.py

diff --git a/build/android/pylib/ports.py b/build/android/pylib/ports.py

index 88b7cb2065c697253066bb3fe62451d596cb4543..34efb5253c425b807f3549eec12707f653c4e744 100644

--- a/build/android/pylib/ports.py

+++ b/build/android/pylib/ports.py

@@ -114,8 +114,7 @@ def IsDevicePortUsed(device, device_port, state=''):

True if the port on device is already used, otherwise returns False.

"""

base_url = '127.0.0.1:%d' % device_port

- netstat_results = device.old_interface.RunShellCommand(

- 'netstat', log_result=False)

+ netstat_results = device.RunShellCommand('netstat')

for single_connect in netstat_results:

# Column 3 is the local address which we want to check with.

connect_results = single_connect.split()

« no previous file with comments | « build/android/pylib/perf/thermal_throttle.py ('k') | build/android/pylib/screenshot.py » ('j') | no next file with comments »