Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Unified Diff: build/android/pylib/perf/surface_stats_collector.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/perf/perf_control_unittest.py ('k') | build/android/pylib/perf/thermal_throttle.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/perf/surface_stats_collector.py
diff --git a/build/android/pylib/perf/surface_stats_collector.py b/build/android/pylib/perf/surface_stats_collector.py
index 223e18c97ce70230cc136378d3e43b74b295fe37..a34d87d144bca82e0f9d140700240f8fdc667fb5 100644
--- a/build/android/pylib/perf/surface_stats_collector.py
+++ b/build/android/pylib/perf/surface_stats_collector.py
@@ -215,7 +215,7 @@ class SurfaceStatsCollector(object):
"""
# The command returns nothing if it is supported, otherwise returns many
# lines of result just like 'dumpsys SurfaceFlinger'.
- results = self._device.old_interface.RunShellCommand(
+ results = self._device.RunShellCommand(
'dumpsys SurfaceFlinger --latency-clear SurfaceView')
return not len(results)
@@ -258,9 +258,8 @@ class SurfaceStatsCollector(object):
# We use the special "SurfaceView" window name because the statistics for
# the activity's main window are not updated when the main web content is
# composited into a SurfaceView.
- results = self._device.old_interface.RunShellCommand(
- 'dumpsys SurfaceFlinger --latency SurfaceView',
- log_result=logging.getLogger().isEnabledFor(logging.DEBUG))
+ results = self._device.RunShellCommand(
+ 'dumpsys SurfaceFlinger --latency SurfaceView')
if not len(results):
return (None, None)
@@ -296,8 +295,7 @@ class SurfaceStatsCollector(object):
Returns:
Dict of {page_flip_count (or 0 if there was an error), timestamp}.
"""
- results = self._device.old_interface.RunShellCommand(
- 'service call SurfaceFlinger 1013')
+ results = self._device.RunShellCommand('service call SurfaceFlinger 1013')
assert len(results) == 1
match = re.search('^Result: Parcel\((\w+)', results[0])
cur_surface = 0
« no previous file with comments | « build/android/pylib/perf/perf_control_unittest.py ('k') | build/android/pylib/perf/thermal_throttle.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698