build/android/pylib/gtest/test_package_apk.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_apk.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/gtest/test_package_apk.py

diff --git a/build/android/pylib/gtest/test_package_apk.py b/build/android/pylib/gtest/test_package_apk.py

index 83b6b001931da392fe2aa84777e983f5ff3c2706..f4315267ff44394a71e36bab6a261eb02a22b32a 100644

--- a/build/android/pylib/gtest/test_package_apk.py

+++ b/build/android/pylib/gtest/test_package_apk.py

@@ -55,7 +55,7 @@ class TestPackageApk(TestPackage):

return '/data/data/' + self._package_info.package + '/files/test.fifo'

def _ClearFifo(self, device):

- device.old_interface.RunShellCommand('rm -f ' + self._GetFifo())

+ device.RunShellCommand('rm -f ' + self._GetFifo())

def _WatchFifo(self, device, timeout, logfile=None):

for i in range(10):

@@ -86,9 +86,9 @@ class TestPackageApk(TestPackage):

# files over time.

if self.suite_name == 'content_browsertests':

try:

- device.old_interface.RunShellCommand(

+ device.RunShellCommand(

'rm -r %s/content_shell' % device.GetExternalStoragePath(),

- timeout_time=60 * 2)

+ timeout=60 * 2)

except device_errors.CommandFailedError:

# TODO(jbudorick) Handle this exception appropriately once the

# conversions are done.

« no previous file with comments | « build/android/pylib/flag_changer.py ('k') | build/android/pylib/gtest/test_package_exe.py » ('j') | no next file with comments »