tools/telemetry/telemetry/core/platform/android_platform_backend.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/android_platform_backend.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ('K') | « tools/telemetry/telemetry/core/forwarders/android_forwarder.py ('k') | tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/android_platform_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/android_platform_backend.py b/tools/telemetry/telemetry/core/platform/android_platform_backend.py

index 5115d595ccbe6f20bf070efb0361094f827916c1..5242cb429d28b84bef24e3927d500ea990c5c0f4 100644

--- a/tools/telemetry/telemetry/core/platform/android_platform_backend.py

+++ b/tools/telemetry/telemetry/core/platform/android_platform_backend.py

@@ -184,8 +184,7 @@ class AndroidPlatformBackend(

raise NotImplementedError()

def FlushDnsCache(self):

- self._device.old_interface.RunShellCommandWithSU(

- 'ndc resolver flushdefaultif')

+ self._device.RunShellCommand('ndc resolver flushdefaultif', root=True)

def LaunchApplication(

self, application, parameters=None, elevate_privilege=False):

@@ -197,8 +196,7 @@ class AndroidPlatformBackend(

raise NotImplementedError("elevate_privilege isn't supported on android.")

if not parameters:

parameters = ''

- self._device.old_interface.RunShellCommand(

- 'am start ' + parameters + ' ' + application)

+ self._device.RunShellCommand('am start ' + parameters + ' ' + application)

def IsApplicationRunning(self, application):

if application in _HOST_APPLICATIONS:

@@ -269,8 +267,7 @@ class AndroidPlatformBackend(

command = 'ps'

if pid:

command += ' -p %d' % pid

- ps = self._device.old_interface.RunShellCommand(

- command, log_result=False)[1:]

tonyg 2014/06/13 23:07:04 Do we still have some control over which ones are

+ ps = self._device.RunShellCommand(command)[1:]

output = []

for line in ps:

data = line.split()