Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2704)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/pylib/utils/emulator.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/pylib/device/device_utils.py ('K') | « build/android/pylib/screenshot.py ('k') | build/android/pylib/valgrind_tools.py » ('j') | tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/utils/emulator.py
diff --git a/build/android/pylib/utils/emulator.py b/build/android/pylib/utils/emulator.py
index 91aa23efb118e4edfecd56182fef64584a2b5d00..81b9c98b2a680e30bde62e88662ef3897d9d2cdd 100644
--- a/build/android/pylib/utils/emulator.py
+++ b/build/android/pylib/utils/emulator.py
@@ -394,6 +394,7 @@ class Emulator(object):
"""
seconds_waited = 0
number_of_waits = 2 # Make sure we can wfd twice
+ # TODO(jbudorick) Un-handroll this in the implementation switch.
adb_cmd = "adb -s %s %s" % (self.device_serial, 'wait-for-device')
while seconds_waited < self._LAUNCH_TIMEOUT:
try:
« build/android/pylib/device/device_utils.py ('K') | « build/android/pylib/screenshot.py ('k') | build/android/pylib/valgrind_tools.py » ('j') | tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698