build/android/enable_asserts.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/enable_asserts.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | build/android/gyp/util/build_device.py » ('j') | no next file with comments »

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 #	2 #

3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6

7 """Enables dalvik vm asserts in the android device."""	7 """Enables dalvik vm asserts in the android device."""

8	8

9 from pylib import android_commands	9 from pylib import android_commands

10 from pylib.device import device_utils	10 from pylib.device import device_utils

(...skipping 12 matching lines...) Expand all Loading...
23 options, _ = option_parser.parse_args(argv)	23 options, _ = option_parser.parse_args(argv)

24	24

25 # TODO(jbudorick): Accept optional serial number and run only for the	25 # TODO(jbudorick): Accept optional serial number and run only for the

26 # specified device when present.	26 # specified device when present.

27 devices = android_commands.GetAttachedDevices()	27 devices = android_commands.GetAttachedDevices()

28 for device in [device_utils.DeviceUtils(serial) for serial in devices]:	28 for device in [device_utils.DeviceUtils(serial) for serial in devices]:

29 if options.set_asserts != None:	29 if options.set_asserts != None:

30 if device.old_interface.SetJavaAssertsEnabled(options.set_asserts):	30 if device.old_interface.SetJavaAssertsEnabled(options.set_asserts):

31 # TODO(jbudorick) How to best do shell restarts after the	31 # TODO(jbudorick) How to best do shell restarts after the

32 # android_commands refactor?	32 # android_commands refactor?

33 device.old_interface.RunShellCommand('stop')	33 device.RunShellCommand('stop')

34 device.old_interface.RunShellCommand('start')	34 device.RunShellCommand('start')

35	35

36	36

37 if __name__ == '__main__':	37 if __name__ == '__main__':

38 main(sys.argv)	38 main(sys.argv)

OLD	NEW