Issue 333903003: Avoid adjusting live bytes in JSObject::MigrateFastToFast() if the size delta is zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333903003: Avoid adjusting live bytes in JSObject::MigrateFastToFast() if the size delta is zero. (Closed)

Created:
6 years, 6 months ago by Igor Sheludko

Modified:
6 years, 4 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Avoid adjusting live bytes in JSObject::MigrateFastToFast() if the size delta is zero. BUG=chromium:388880 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22031

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	src/objects.cc	View		2 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

Committed patchset #1 manually as r22031 (tree was closed).

6 years, 6 months ago (2014-06-26 08:34:41 UTC) #3

jochen (gone - plz use gerrit)

is it possible to add a test for this?

6 years, 5 months ago (2014-07-11 07:10:07 UTC) #4

Igor Sheludko

On 2014/07/11 07:10:07, jochen wrote: > is it possible to add a test for this? ...

6 years, 5 months ago (2014-07-11 07:24:36 UTC) #5

Igor Sheludko

6 years, 4 months ago (2014-07-28 15:36:31 UTC) #6

Message was sent while issue was closed.

On 2014/07/11 07:24:36, Igor Sheludko wrote:
> On 2014/07/11 07:10:07, jochen wrote:
> > is it possible to add a test for this?
> 
> I'll try to make a test.

Test added: https://codereview.chromium.org/424693006/

Expand Messages | Collapse Messages