Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 333823007: Enable basic drawing with SkRecord-based pictures. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Enable basic drawing with SkRecord-based pictures. I've tagged all the functions in SkPicture.cpp is // fRecord TODO or // fRecord OK, depending on whether or not they're totally broken when used from an SkRecord-based picture. Obviously next steps are to eliminate all the TODOs, then clean up the notes. I converted SkPicture over to smart pointers too. It's particularly helpful that the smart pointers initialize to NULL by default. For now I've got all the SkRecord-based code jammed in at the bottom of the file. I figure it'll help me keep things straight for a bit, then we can rearrange later. BUG=skia: R=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/744fb73

Patch Set 1 #

Patch Set 2 : tag more #

Total comments: 4

Patch Set 3 : robert #

Patch Set 4 : ref accel data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -88 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M include/core/SkPicture.h View 4 chunks +11 lines, -12 lines 0 comments Download
M src/core/SkPicture.cpp View 1 2 3 18 chunks +89 lines, -40 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/bench_playback.cpp View 7 chunks +9 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
6 years, 6 months ago (2014-06-23 18:20:37 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/333823007/diff/20001/src/core/SkPicture.cpp File src/core/SkPicture.cpp (right): https://codereview.chromium.org/333823007/diff/20001/src/core/SkPicture.cpp#newcode299 src/core/SkPicture.cpp:299: void SkPicture::draw(SkCanvas* canvas, SkDrawPictureCallback* callback) const ...
6 years, 6 months ago (2014-06-23 18:53:19 UTC) #2
mtklein
https://codereview.chromium.org/333823007/diff/20001/src/core/SkPicture.cpp File src/core/SkPicture.cpp (right): https://codereview.chromium.org/333823007/diff/20001/src/core/SkPicture.cpp#newcode299 src/core/SkPicture.cpp:299: void SkPicture::draw(SkCanvas* canvas, SkDrawPictureCallback* callback) const { On 2014/06/23 ...
6 years, 6 months ago (2014-06-23 18:55:45 UTC) #3
mtklein_C
6 years, 6 months ago (2014-06-23 19:13:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r744fb73.

Powered by Google App Engine
This is Rietveld 408576698