Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 333813004: Oilpan: Make MediaControllers ExecutionContext a weak pointer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: nullptr Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/MediaController.h » ('j') | Source/core/html/MediaController.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index 13c824a8b3de7745340fbeacc4afa320259a8ab7..8388b864111e9f53da11de3acf520e97bd40cfb7 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -3190,8 +3190,12 @@ bool HTMLMediaElement::hasPendingActivity() const
void HTMLMediaElement::contextDestroyed()
{
+ // With Oilpan the ExecutionContext is weakly referenced from the media
+ // controller and so it will clear itself on destruction.
+#if !ENABLE(OILPAN)
if (m_mediaController)
m_mediaController->clearExecutionContext();
+#endif
ActiveDOMObject::contextDestroyed();
}
« no previous file with comments | « no previous file | Source/core/html/MediaController.h » ('j') | Source/core/html/MediaController.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698