Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 333813002: Focus plugin on gesturetapdown. (Closed)

Created:
6 years, 6 months ago by lazyboy
Modified:
6 years, 6 months ago
Reviewers:
kevers, abarth-chromium
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Focus plugin on gesturetapdown. We focus the plugin on mousedown/touchstart, so similarly we should focus it on gesturetapdown. This fixes IME input on plugins, if a plugin gets gesturetapdown without any mousedown/touchstart, the plugin will be focused correctly and input fed to the plugin would work properly. This could happen if the plugin doesn't have any touch handlers, then tapping sends gesture event(s) to plugin, without any touchstart. BUG=383484 Test=Using chrome app webview, which is a plugin. Enable virutal keyboard in chrome://flags if it's not enabled. In chromebook pixel: load the sample browser app https://github.com/GoogleChrome/chrome-app-samples/tree/master/webview-samples/browser Navigate to a simple page that has <input> element, e.g. http://jsbin.com/togif/1/ Now without generating any mouse/touchpad inside the content area, tap on the screen on the input box in the jsbin page. Notice virtual keyboard opening and it is possible to type stuffs into the input box. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176152

Patch Set 1 #

Patch Set 2 : Remove debug code. #

Patch Set 3 : use gesturetapdown instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/web/WebPluginContainerImpl.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
lazyboy
+Kevin for initial review.
6 years, 6 months ago (2014-06-13 00:06:46 UTC) #1
kevers
lgtm
6 years, 6 months ago (2014-06-13 17:47:56 UTC) #2
lazyboy
+Adam for OWNERS review.
6 years, 6 months ago (2014-06-13 17:56:37 UTC) #3
abarth-chromium
It looks like we already focus the plugin on touchstart. Is there some way to ...
6 years, 6 months ago (2014-06-13 21:50:39 UTC) #4
lazyboy
On 2014/06/13 21:50:39, abarth wrote: > It looks like we already focus the plugin on ...
6 years, 6 months ago (2014-06-14 01:18:30 UTC) #5
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-14 03:19:56 UTC) #6
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 6 months ago (2014-06-14 04:00:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/333813002/40001
6 years, 6 months ago (2014-06-14 04:01:05 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 05:02:25 UTC) #9
Message was sent while issue was closed.
Change committed as 176152

Powered by Google App Engine
This is Rietveld 408576698