Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 333803007: Rather than passing initial_flow_control_window all the way down the (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc, avd
Project:
chromium
Visibility:
Public.

Description

Rather than passing initial_flow_control_window all the way down the call stack, put it inside QuicConfig as intended: each member of QuicConfig has a "value to send" field, so populate this at the top level. rtenneti: when porting to Chromium, you should add config.SetInitialFlowControlWindowToSend(kInitialReceiveWindowSize) in QuicStreamFactory::CreateSession, just above line 837: *session = new QuicClientSession(...) Store initial flow control window for QUIC in QuicConfig. No behavior change intended. Added the following unit tests to EndToEndTest.cc + DoNotSetResumeWriteAlarmIfConnectionFlowControlBlocked + NegotiateMaxOpenStreams Merge internal change: 69079363 R=rch@chromium.org, rjshade@google.com

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -247 lines) Patch
M net/quic/crypto/crypto_server_test.cc View 2 chunks +2 lines, -33 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 2 chunks +0 lines, -4 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/quic/quic_client_session.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_client_session_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_client_session_base.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/quic/quic_config.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_config.cc View 2 chunks +13 lines, -1 line 0 comments Download
M net/quic/quic_config_test.cc View 8 chunks +26 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_session.h View 3 chunks +0 lines, -8 lines 0 comments Download
M net/quic/quic_session.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M net/quic/quic_session_test.cc View 10 chunks +21 lines, -39 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 11 chunks +80 lines, -13 lines 0 comments Download
M net/tools/quic/quic_client.h View 2 chunks +3 lines, -7 lines 0 comments Download
M net/tools/quic/quic_client.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_session.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 3 chunks +1 line, -10 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_server.cc View 4 chunks +7 lines, -10 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 2 chunks +3 lines, -6 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 6 chunks +9 lines, -16 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-13 19:08:06 UTC) #1
Ryan Hamilton
lgtm
6 years, 6 months ago (2014-06-13 20:21:37 UTC) #2
Robbie Shade
6 years, 6 months ago (2014-06-13 21:16:17 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698