Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 333803004: Revert 276998 "Remove recovery diagnostics for the archived hist..." (Closed)

Created:
6 years, 6 months ago by not at google - send to devlin
Modified:
6 years, 6 months ago
Reviewers:
engedy
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 276998 "Remove recovery diagnostics for the archived hist..." Broke Linux ChromiumOS Tests. > Remove recovery diagnostics for the archived history database. > > The reason is that the archived history database feature has been removed as of r275159. > > BUG=359377 > > Review URL: https://codereview.chromium.org/316063003 TBR=engedy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M trunk/src/chrome/browser/diagnostics/diagnostics_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/diagnostics/diagnostics_metrics.cc View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/diagnostics/diagnostics_model.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
not at google - send to devlin
6 years, 6 months ago (2014-06-13 16:03:56 UTC) #1
not at google - send to devlin
Failures are here: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35819 For example, (view as text) AccessibilityManagerTest.AcessibilityMenuVisibility (run #1): [ RUN ] ...
6 years, 6 months ago (2014-06-13 16:09:16 UTC) #2
not at google - send to devlin
6 years, 6 months ago (2014-06-13 16:09:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r277030 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698