Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 333783002: Fix tiled (stitched) FETurbulence. (Closed)

Created:
6 years, 6 months ago by Stephen White
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Fix tiled (stitched) FETurbulence. The legacy implementation of FETurbulence actually never generated tile-able noise. The algorithmic problem was fixed in Skia (https://codereview.chromium.org/332523006/), but Blink was also not passing the tile size (filter primitive subregion) to the turbulence shader. This change fixes the latter (small) problem. BUG=383495 R=fmalita Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176121

Patch Set 1 #

Patch Set 2 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/svg/filters/feTurbulence-tiled.svg View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/platform/graphics/filters/FETurbulence.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FETurbulence.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Stephen White
fmalita: PTAL. Thanks!
6 years, 6 months ago (2014-06-12 20:53:59 UTC) #1
f(malita)
lgtm
6 years, 6 months ago (2014-06-13 14:26:45 UTC) #2
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 6 months ago (2014-06-13 14:51:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/333783002/1
6 years, 6 months ago (2014-06-13 14:52:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 14:53:05 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-13 14:53:06 UTC) #6
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 6 months ago (2014-06-13 14:56:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/333783002/20001
6 years, 6 months ago (2014-06-13 14:56:31 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-13 16:07:48 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 16:51:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11931)
6 years, 6 months ago (2014-06-13 16:51:25 UTC) #11
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 6 months ago (2014-06-13 17:05:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/333783002/20001
6 years, 6 months ago (2014-06-13 17:07:03 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 18:23:28 UTC) #14
Message was sent while issue was closed.
Change committed as 176121

Powered by Google App Engine
This is Rietveld 408576698