Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 333743002: Rename LayoutStateDisabler to ForceHorriblySlowRectMapping (Closed)

Created:
6 years, 6 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 6 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, chromiumbugtracker_adobe.com, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, feature-media-reviews_chromium.org, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr., philipj_slow, rwlbuis, rune+blink, Stephen Chennney, zoltan1
Project:
blink
Visibility:
Public.

Description

Rename LayoutStateDisabler to ForceHorriblySlowRectMapping LayoutState keeps track of a handful of fields, but the most important part is providing a fast-mapping between renderers and their repaint container. For parts where the logic doesn't work, we disable LayoutState, which causes us to fall back on walking up the tree and slowly calculating our rects. Renaming LayoutStateDisabler, which sounds relatively innocuous and which most people have no idea of the implications of to ForceHorriblySlowRectMapping, with the hopes of striking fear into any dev or reviewer who hopes to introduce one. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176052

Patch Set 1 : Stack stack stack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -306 lines) Patch
M Source/core/frame/FrameView.cpp View 3 chunks +3 lines, -29 lines 0 comments Download
M Source/core/rendering/LayoutState.h View 3 chunks +27 lines, -29 lines 0 comments Download
M Source/core/rendering/LayoutState.cpp View 4 chunks +51 lines, -21 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMedia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 4 chunks +4 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderVTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.h View 6 chunks +25 lines, -144 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 6 chunks +2 lines, -47 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
leviw_travelin_and_unemployed
6 years, 6 months ago (2014-06-12 18:28:37 UTC) #1
ojan
lgtm <3
6 years, 6 months ago (2014-06-12 18:35:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/333743002/1
6 years, 6 months ago (2014-06-12 18:35:52 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-12 20:17:06 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 21:34:35 UTC) #5
Message was sent while issue was closed.
Change committed as 176052

Powered by Google App Engine
This is Rietveld 408576698