Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 33373002: Drop unused variable in rlz_value_store_chromeos.cc. (Closed)

Created:
7 years, 2 months ago by xhwang
Modified:
7 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Drop unused variable in rlz_value_store_chromeos.cc. ../../rlz/chromeos/lib/rlz_value_store_chromeos.cc:24:12: error: unused variable 'kProductChrome' [-Werror,-Wunused-const-variable] const char kProductChrome[] = "chrome"; ^ ../../rlz/chromeos/lib/rlz_value_store_chromeos.cc:25:12: error: unused variable 'kProductOther' [-Werror,-Wunused-const-variable] const char kProductOther[] = "other"; ^ 2 errors generated. BUG=307668 TEST=none R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229874

Patch Set 1 #

Patch Set 2 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M rlz/chromeos/lib/rlz_value_store_chromeos.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xhwang
PTAL
7 years, 2 months ago (2013-10-21 18:37:05 UTC) #1
Nico
lgtm, thanks (Why is this not built on bots?)
7 years, 2 months ago (2013-10-21 18:45:33 UTC) #2
xhwang
On 2013/10/21 18:45:33, Nico wrote: > lgtm, thanks > > (Why is this not built ...
7 years, 2 months ago (2013-10-21 19:00:49 UTC) #3
Nico
Ah, we probably don't have a branding=Chrome clang builder for chromeos. On Mon, Oct 21, ...
7 years, 2 months ago (2013-10-21 19:01:38 UTC) #4
xhwang
rebase only
7 years, 2 months ago (2013-10-21 19:02:51 UTC) #5
xhwang
7 years, 2 months ago (2013-10-21 19:03:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r229874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698