Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 333723004: Fix set_area sizes for RequestCopyOfOutput (Closed)

Created:
6 years, 6 months ago by powei
Modified:
6 years, 4 months ago
CC:
aelias_OOO_until_Jul13, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix set_area sizes for RequestCopyOfOutput Layers are in DIP space, we should use subrects in the same space for RequestCopyOfOutput. Also moved the force-device-scale command line option to its proper place. This ensures that the flag is set before the scale factors are checked. Previous tests were blindly passing due to the scale factors not being supported. The switch to DIP is here: https://codereview.chromium.org/311253004 BUG=

Patch Set 1 #

Patch Set 2 : force-dsf command line fix #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M content/browser/compositor/delegated_frame_host.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 2 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
powei
PTAL. Came across this while trying to fix related issue on Android. We're going with ...
6 years, 6 months ago (2014-06-13 01:48:17 UTC) #1
danakj
Thanks! This looks good, do you know why tests like CompositingRenderWidgetHostViewTabCaptureHighDPI.CopyFromCompositingSurfaceVideoFrame aren't failing before (or ...
6 years, 6 months ago (2014-06-13 15:14:04 UTC) #2
powei
On 2014/06/13 15:14:04, danakj wrote: > Thanks! This looks good, do you know why tests ...
6 years, 6 months ago (2014-06-17 21:20:48 UTC) #3
danakj
Thanks, so the test fails now without the changes to the frame host etc? LGTM
6 years, 6 months ago (2014-06-17 21:45:26 UTC) #4
powei
On 2014/06/17 21:45:26, danakj wrote: > Thanks, so the test fails now without the changes ...
6 years, 6 months ago (2014-06-17 21:55:11 UTC) #5
powei
The CQ bit was checked by powei@chromium.org
6 years, 6 months ago (2014-06-17 21:55:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/powei@chromium.org/333723004/20001
6 years, 6 months ago (2014-06-17 21:56:56 UTC) #7
powei
+miu@ for content/browser/media/capture and content/browser/renderer_host/ OWNERS
6 years, 6 months ago (2014-06-17 22:07:26 UTC) #8
miu
Very much lgtm! :)
6 years, 6 months ago (2014-06-17 22:59:18 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 08:28:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74478)
6 years, 6 months ago (2014-06-18 08:28:34 UTC) #11
danakj
+sievers for OWNERS
6 years, 6 months ago (2014-06-18 15:19:24 UTC) #12
no sievers
lgtm
6 years, 6 months ago (2014-06-18 21:18:42 UTC) #13
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 6 months ago (2014-06-18 21:19:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/powei@chromium.org/333723004/20001
6 years, 6 months ago (2014-06-18 21:20:46 UTC) #15
powei
On 2014/06/18 21:20:46, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-19 00:27:10 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 10:40:34 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/29584)
6 years, 6 months ago (2014-06-19 10:40:35 UTC) #18
miu
powei: Did you still want to land this change?
6 years, 4 months ago (2014-08-12 04:36:18 UTC) #19
aelias_OOO_until_Jul13
Powei left Google last week, unfortunately. Someone else will need to look into the windows ...
6 years, 4 months ago (2014-08-12 18:28:52 UTC) #20
miu
On 2014/08/12 18:28:52, aelias wrote: > Powei left Google last week, unfortunately. Someone else will ...
6 years, 4 months ago (2014-08-12 18:40:39 UTC) #21
miu
6 years, 4 months ago (2014-08-12 19:14:21 UTC) #22
Message was sent while issue was closed.
On 2014/08/12 18:40:39, miu wrote:
> Alright.  I'll take over this change.  Looks like we have all the LGTM's here,
> and the commit box was checked, so the intention that this should land is
clear.

Closed this issue, and started a continuation here:
https://codereview.chromium.org/462173002

Powered by Google App Engine
This is Rietveld 408576698