Wait for perfbot devices to charge between runs.

Wait for perfbot devices to charge between runs.

We were draining the battery faster than it was charging. So this causes us to
sleep until battery is at least 95% charged.

BUG=379807
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277163

[jbudorick, 2014-06-13 16:43:56]

https://codereview.chromium.org/333723003/diff/20001/build/android/buildbot/b...
File build/android/buildbot/bb_device_status_check.py (right):

https://codereview.chromium.org/333723003/diff/20001/build/android/buildbot/b...
build/android/buildbot/bb_device_status_check.py:76: ''.join(['    %s: %s' % (k,
v) for k, v in battery_info]),
Doesn't this concatenate everything onto one line? Is that what you want?

https://codereview.chromium.org/333723003/diff/20001/build/android/provision_...
File build/android/provision_devices.py (right):

https://codereview.chromium.org/333723003/diff/20001/build/android/provision_...
build/android/provision_devices.py:155: # Some perf bots run benchmarks with USB
charging disabled which leads
Would we want to try to enable USB charging here if it's disabled?

[tonyg, 2014-06-13 17:13:35]

> Doesn't this concatenate everything onto one line? Is that what you want?

Oops, thanks for catching that. Fixed and I verified the output is identical to
before.

> Would we want to try to enable USB charging here if it's disabled?

Great idea. Done.

[navabi, 2014-06-13 20:35:15]

https://codereview.chromium.org/333723003/diff/60001/build/android/buildbot/b...
File build/android/buildbot/bb_device_status_check.py (right):

https://codereview.chromium.org/333723003/diff/60001/build/android/buildbot/b...
build/android/buildbot/bb_device_status_check.py:68: battery_level =
int(battery_info.get('level', 0))
If the battery level can not be taken from the device for whatever reason (e.g.
I think we had that problem on some of the x86 devices we got), it looks like
this will set battery_level to 0, and thus never run because of the
battery_level < 15 check below.

Is that right? If so, let's not do that. If the device doesn't give us the level
as we expect, I think we should just keep running.

[tonyg, 2014-06-13 20:38:45]

On 2014/06/13 20:35:15, navabi wrote:
>
https://codereview.chromium.org/333723003/diff/60001/build/android/buildbot/b...
> File build/android/buildbot/bb_device_status_check.py (right):
> 
>
https://codereview.chromium.org/333723003/diff/60001/build/android/buildbot/b...
> build/android/buildbot/bb_device_status_check.py:68: battery_level =
> int(battery_info.get('level', 0))
> If the battery level can not be taken from the device for whatever reason
(e.g.
> I think we had that problem on some of the x86 devices we got), it looks like
> this will set battery_level to 0, and thus never run because of the
> battery_level < 15 check below.
> 
> Is that right? If so, let's not do that. If the device doesn't give us the
level
> as we expect, I think we should just keep running.

Good catch. It now assumes fully charged if it cannot be determined.

[navabi, 2014-06-13 20:49:17]

lgtm

[tonyg, 2014-06-13 20:54:13]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-13 20:55:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/333723003/80001

[navabi1, 2014-06-14 00:42:31]

lgtm

[commit-bot: I haz the power, 2014-06-14 02:58:39]

Change committed as 277163