chrome/renderer/resources/extensions/web_view_experimental.js - Issue 333713005: Move event stuff of web_view.js to its own class/file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view_experimental.js

Issue 333713005: Move event stuff of web_view.js to its own class/file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from fady Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/web_view_experimental.js

diff --git a/chrome/renderer/resources/extensions/web_view_experimental.js b/chrome/renderer/resources/extensions/web_view_experimental.js

index 311de4640502b8c6e4442890885c1fe30b36ff5b..c927d2a4a7f0297f4a17ada1d7d65d0c06c61169 100644

--- a/chrome/renderer/resources/extensions/web_view_experimental.js

+++ b/chrome/renderer/resources/extensions/web_view_experimental.js

@@ -10,7 +10,7 @@

var ContextMenusSchema =

requireNative('schema_registry').GetSchema('contextMenus');

-var CreateEvent = require('webView').CreateEvent;

+var CreateEvent = require('webViewEvents').CreateEvent;

var EventBindings = require('event_bindings');

var MessagingNatives = requireNative('messaging_natives');

var WebView = require('webView').WebView;

@@ -245,7 +245,7 @@ WebViewInternal.maybeRegisterExperimentalAPIs = function(proto) {

};

/** @private */

-WebViewInternal.prototype.setupExperimentalContextMenus_ = function() {

+WebViewInternal.prototype.setupExperimentalContextMenus = function() {

var self = this;

var createContextMenus = function() {

return function() {

« no previous file with comments | « chrome/renderer/resources/extensions/web_view_events.js ('k') | chrome/renderer/resources/renderer_resources.grd » ('j') | no next file with comments »