Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 333713004: Subzero: give crosstest .sz intermediate files names that depend on flags (Closed)

Created:
6 years, 6 months ago by jvoung (off chromium)
Modified:
6 years, 6 months ago
Reviewers:
Jim Stichnoth, JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: give crosstest .sz intermediate files names that depend on flags Currently only the output has a unique name (supplied by the invocation), but the intermediate files (.sz.s, .sz.o) can get overwritten (w/ different optlevels, or targets). Would be nice to keep them around for debugging. (bug may happen for Om1 but not O2). BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=798b415

Patch Set 1 #

Patch Set 2 : add target too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M crosstest/crosstest.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvoung (off chromium)
6 years, 6 months ago (2014-06-12 18:17:34 UTC) #1
Jim Stichnoth
LGTM. Minor concerns about whether raw transplant of command-line arguments into output filenames will yield ...
6 years, 6 months ago (2014-06-12 18:27:29 UTC) #2
jvoung (off chromium)
6 years, 6 months ago (2014-06-12 19:54:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r798b415 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698