Issue 333713002: MIPS: Fix r21780 - “Fixed flooring division by a power of 2, once again...”

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333713002: MIPS: Fix r21780 - “Fixed flooring division by a power of 2, once again...” (Closed)

Created:
6 years, 6 months ago by kilvadyb

Modified:
6 years, 6 months ago

Reviewers:
kisg, Paul Lind, palfia, danno, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Fix r21780 - “Fixed flooring division by a power of 2, once again...” Initialize scratch register for all possible code paths. TEST=mjsunit/compiler/division-by-constant.js BUG=

Patch Set 1 #

Patch Set 2 : Fix register usage. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Committed as r21822.

Expand Messages | Collapse Messages