Issue 333683004: Revert of Use the updated AMD switchable info collection code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333683004: Revert of Use the updated AMD switchable info collection code. (Closed)

Created:
6 years, 6 months ago by please use gerrit instead

Modified:
6 years, 6 months ago

Reviewers:
Ken Russell (switch to Gerrit), Zhenyao Mo

CC:
chromium-reviews, piman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Use the updated AMD switchable info collection code. (https://codereview.chromium.org/332843003/) Reason for revert: The patch appears to have broken windows perf bot: http://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/69732 Original issue's description: > Use the updated AMD switchable info collection code. > > BUG=376562 > TEST= > R=kbr@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276865 TBR=kbr@chromium.org,zmo@chromium.org NOTREECHECKS=true NOTRY=true BUG=376562 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276879

Patch Set 1 #

Created: 6 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -14 lines)			Patch
	M	gpu/config/gpu_info_collector.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	gpu/config/gpu_info_collector_win.cc	View		2 chunks	+6 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

please use gerrit instead

Created Revert of Use the updated AMD switchable info collection code.

6 years, 6 months ago (2014-06-13 01:28:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/333683004/1

6 years, 6 months ago (2014-06-13 01:29:56 UTC) #2

Zhenyao Mo

6 years, 6 months ago (2014-06-13 17:34:03 UTC) #4

Message was sent while issue was closed.

Ah I landed the internal change but forget to roll the DEPS.  Unfortunately on
my local bot when I tested, the change is manually pulled in, so I never
realized the mistake.

Expand Messages | Collapse Messages