Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Side by Side Diff: Source/core/page/WindowFeatures.cpp

Issue 333643008: WindowFeatures arguments shoud ignore invalid characters in values (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Maybe update the expected.txt next time Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Harri Porten (porten@kde.org) 2 * Copyright (C) 2000 Harri Porten (porten@kde.org)
3 * Copyright (C) 2006 Jon Shier (jshier@iastate.edu) 3 * Copyright (C) 2006 Jon Shier (jshier@iastate.edu)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights resev ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights resev ed.
5 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Lesser General Public 8 * modify it under the terms of the GNU Lesser General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 return; 67 return;
68 } 68 }
69 69
70 menuBarVisible = false; 70 menuBarVisible = false;
71 statusBarVisible = false; 71 statusBarVisible = false;
72 toolBarVisible = false; 72 toolBarVisible = false;
73 locationBarVisible = false; 73 locationBarVisible = false;
74 scrollbarsVisible = false; 74 scrollbarsVisible = false;
75 75
76 // Tread lightly in this code -- it was specifically designed to mimic Win I E's parsing behavior. 76 // Tread lightly in this code -- it was specifically designed to mimic Win I E's parsing behavior.
77 int keyBegin, keyEnd; 77 unsigned keyBegin, keyEnd;
78 int valueBegin, valueEnd; 78 unsigned valueBegin, valueEnd;
79 79
80 int i = 0;
81 int length = features.length();
82 String buffer = features.lower(); 80 String buffer = features.lower();
83 while (i < length) { 81 unsigned length = buffer.length();
82 for (unsigned i = 0; i < length; ) {
84 // skip to first non-separator, but don't skip past the end of the strin g 83 // skip to first non-separator, but don't skip past the end of the strin g
85 while (i < length && isWindowFeaturesSeparator(buffer[i])) 84 while (i < length && isWindowFeaturesSeparator(buffer[i]))
86 i++; 85 i++;
87 keyBegin = i; 86 keyBegin = i;
88 87
89 // skip to first separator 88 // skip to first separator
90 while (i < length && !isWindowFeaturesSeparator(buffer[i])) 89 while (i < length && !isWindowFeaturesSeparator(buffer[i]))
91 i++; 90 i++;
92 keyEnd = i; 91 keyEnd = i;
93 92
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 if (separatorPosition != kNotFound) { 261 if (separatorPosition != kNotFound) {
263 value = featureString.substring(separatorPosition + 1).stripWhiteSpa ce().lower(); 262 value = featureString.substring(separatorPosition + 1).stripWhiteSpa ce().lower();
264 value = value.left(value.find(' ')); 263 value = value.left(value.find(' '));
265 } 264 }
266 265
267 map.set(key, value); 266 map.set(key, value);
268 } 267 }
269 } 268 }
270 269
271 } // namespace WebCore 270 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698