LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored.html - Issue 333643008: WindowFeatures arguments shoud ignore invalid characters in values

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored.html

Issue 333643008: WindowFeatures arguments shoud ignore invalid characters in values (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update test further since our tests are different from webkits Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 <script>

	6 jsTestIsAsync = true;

	7

	8 if (window.testRunner) {

	9 testRunner.waitUntilDone();

	10 testRunner.setCanOpenWindows();

	11 }

	12

	13 description("Tests that invalid characters are ignored after a window property v alue.");

	14

	15 var w = window.open("resources/window-property-invalid-characters-ignored.html", "blank", "width=123\u0130,height=123\u0130");
	cbiesinger 2014/06/12 23:49:39 This test doesn't test what the code is changing, This test doesn't test what the code is changing, I think. However, I'm not sure what a good test for the code change is. For reference, here's what happens: U+0130 = LATIN CAPITAL LETTER I WITH DOT ABOVE which gets lowercased to: U+0069 LATIN SMALL LETTER I U+0307 COMBINING DOT ABOVE I don't know why we add that combining dot. Maybe we decompose the string before lowering it...? Note that Firefox does not lowercase the string the way we do: "\u0130".length 1 "\u0130".toLowerCase().length 1 "\u0130".toLowerCase().charCodeAt(0).toString(16) "69"
	16

	17 function finishTest()

	18 {

	19 shouldBe("w.innerWidth", "123");

	20 shouldBe("w.innerHeight", "123");

	21 shouldBeTrue("w !== window");

	22 w.close();

	23

	24 finishJSTest();

	25 }

	26

	27 </script>

	28 </head>

	29 <body>

	30 <pre id="console"></pre>

	31 </body>

	32 </html>

OLD	NEW